Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Redesign inplace conversion (#55033) #56173

Closed
wants to merge 5 commits into from

Commits on Apr 15, 2021

  1. [ONNX] Redesign inplace conversion (#55033)

    * Create `InplaceConverter` and `ValueTracker` to keep track of aliases of values throughout the graph. For a given value, a new alias is created every time when there is an inplace operation, SetAttr, or through nested blocks owned by If/Loop nodes.
    * Fix bug where controlflow node output types are not set, when the complete node is unable to run ONNX shape inference due to containing non-onnx node.
    * Add symbolic for `__not__` ~~and `prim_min`~~(update: moved to a separate PR), and update `index_put` opset9 to support case of assignment without providing indices.
    * Bump ORT version in CI test.
    
    [ghstack-poisoned]
    BowenBao committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    87d5494 View commit details
    Browse the repository at this point in the history
  2. Update on "[ONNX] Redesign inplace conversion (#55033)"

    * Create `InplaceConverter` and `ValueTracker` to keep track of aliases of values throughout the graph. For a given value, a new alias is created every time when there is an inplace operation, SetAttr, or through nested blocks owned by If/Loop nodes.
    * Fix bug where controlflow node output types are not set, when the complete node is unable to run ONNX shape inference due to containing non-onnx node.
    * Add symbolic for `__not__` ~~and `prim_min`~~(update: moved to a separate PR), and update `index_put` opset9 to support case of assignment without providing indices.
    * Bump ORT version in CI test.
    
    [ghstack-poisoned]
    BowenBao committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    fe26650 View commit details
    Browse the repository at this point in the history
  3. Update on "[ONNX] Redesign inplace conversion (#55033)"

    * Create `InplaceConverter` and `ValueTracker` to keep track of aliases of values throughout the graph. For a given value, a new alias is created every time when there is an inplace operation, SetAttr, or through nested blocks owned by If/Loop nodes.
    * Fix bug where controlflow node output types are not set, when the complete node is unable to run ONNX shape inference due to containing non-onnx node.
    * Add symbolic for `__not__` ~~and `prim_min`~~(update: moved to a separate PR), and update `index_put` opset9 to support case of assignment without providing indices.
    * Bump ORT version in CI test.
    
    [ghstack-poisoned]
    BowenBao committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    51ce0b7 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2021

  1. Update on "[ONNX] Redesign inplace conversion (#55033)"

    * Create `InplaceConverter` and `ValueTracker` to keep track of aliases of values throughout the graph. For a given value, a new alias is created every time when there is an inplace operation, SetAttr, or through nested blocks owned by If/Loop nodes.
    * Fix bug where controlflow node output types are not set, when the complete node is unable to run ONNX shape inference due to containing non-onnx node.
    * Add symbolic for `__not__` ~~and `prim_min`~~(update: moved to a separate PR), and update `index_put` opset9 to support case of assignment without providing indices.
    * Bump ORT version in CI test.
    
    [ghstack-poisoned]
    BowenBao committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    4380ac5 View commit details
    Browse the repository at this point in the history
  2. Update on "[ONNX] Redesign inplace conversion (#55033)"

    * Create `InplaceConverter` and `ValueTracker` to keep track of aliases of values throughout the graph. For a given value, a new alias is created every time when there is an inplace operation, SetAttr, or through nested blocks owned by If/Loop nodes.
    * Fix bug where controlflow node output types are not set, when the complete node is unable to run ONNX shape inference due to containing non-onnx node.
    * Add symbolic for `__not__` ~~and `prim_min`~~(update: moved to a separate PR), and update `index_put` opset9 to support case of assignment without providing indices.
    * Bump ORT version in CI test.
    
    [ghstack-poisoned]
    BowenBao committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    834bd40 View commit details
    Browse the repository at this point in the history