-
Notifications
You must be signed in to change notification settings - Fork 22.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ONNX] Redesign inplace conversion (#55033) #56173
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create `InplaceConverter` and `ValueTracker` to keep track of aliases of values throughout the graph. For a given value, a new alias is created every time when there is an inplace operation, SetAttr, or through nested blocks owned by If/Loop nodes. * Fix bug where controlflow node output types are not set, when the complete node is unable to run ONNX shape inference due to containing non-onnx node. * Add symbolic for `__not__` ~~and `prim_min`~~(update: moved to a separate PR), and update `index_put` opset9 to support case of assignment without providing indices. * Bump ORT version in CI test. [ghstack-poisoned]
This was referenced Apr 15, 2021
facebook-github-bot
added
oncall: jit
Add this issue/PR to JIT oncall triage queue
cla signed
labels
Apr 15, 2021
💊 CI failures summary and remediationsAs of commit 834bd40 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
* Create `InplaceConverter` and `ValueTracker` to keep track of aliases of values throughout the graph. For a given value, a new alias is created every time when there is an inplace operation, SetAttr, or through nested blocks owned by If/Loop nodes. * Fix bug where controlflow node output types are not set, when the complete node is unable to run ONNX shape inference due to containing non-onnx node. * Add symbolic for `__not__` ~~and `prim_min`~~(update: moved to a separate PR), and update `index_put` opset9 to support case of assignment without providing indices. * Bump ORT version in CI test. [ghstack-poisoned]
* Create `InplaceConverter` and `ValueTracker` to keep track of aliases of values throughout the graph. For a given value, a new alias is created every time when there is an inplace operation, SetAttr, or through nested blocks owned by If/Loop nodes. * Fix bug where controlflow node output types are not set, when the complete node is unable to run ONNX shape inference due to containing non-onnx node. * Add symbolic for `__not__` ~~and `prim_min`~~(update: moved to a separate PR), and update `index_put` opset9 to support case of assignment without providing indices. * Bump ORT version in CI test. [ghstack-poisoned]
* Create `InplaceConverter` and `ValueTracker` to keep track of aliases of values throughout the graph. For a given value, a new alias is created every time when there is an inplace operation, SetAttr, or through nested blocks owned by If/Loop nodes. * Fix bug where controlflow node output types are not set, when the complete node is unable to run ONNX shape inference due to containing non-onnx node. * Add symbolic for `__not__` ~~and `prim_min`~~(update: moved to a separate PR), and update `index_put` opset9 to support case of assignment without providing indices. * Bump ORT version in CI test. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Apr 16, 2021
* Create `InplaceConverter` and `ValueTracker` to keep track of aliases of values throughout the graph. For a given value, a new alias is created every time when there is an inplace operation, SetAttr, or through nested blocks owned by If/Loop nodes. * Fix bug where controlflow node output types are not set, when the complete node is unable to run ONNX shape inference due to containing non-onnx node. * Add symbolic for `__not__` ~~and `prim_min`~~(update: moved to a separate PR), and update `index_put` opset9 to support case of assignment without providing indices. * Bump ORT version in CI test. ghstack-source-id: 338781ce164798fd375f1a2d0e9f1267deb7746b Pull Request resolved: #56173
* Create `InplaceConverter` and `ValueTracker` to keep track of aliases of values throughout the graph. For a given value, a new alias is created every time when there is an inplace operation, SetAttr, or through nested blocks owned by If/Loop nodes. * Fix bug where controlflow node output types are not set, when the complete node is unable to run ONNX shape inference due to containing non-onnx node. * Add symbolic for `__not__` ~~and `prim_min`~~(update: moved to a separate PR), and update `index_put` opset9 to support case of assignment without providing indices. * Bump ORT version in CI test. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Apr 16, 2021
* Create `InplaceConverter` and `ValueTracker` to keep track of aliases of values throughout the graph. For a given value, a new alias is created every time when there is an inplace operation, SetAttr, or through nested blocks owned by If/Loop nodes. * Fix bug where controlflow node output types are not set, when the complete node is unable to run ONNX shape inference due to containing non-onnx node. * Add symbolic for `__not__` ~~and `prim_min`~~(update: moved to a separate PR), and update `index_put` opset9 to support case of assignment without providing indices. * Bump ORT version in CI test. ghstack-source-id: ce4d92556a77357a230303e22b54a24b8ab2a9be Pull Request resolved: #56173
Codecov Report
@@ Coverage Diff @@
## gh/BowenBao/49/base #56173 +/- ##
=======================================================
+ Coverage 77.01% 77.03% +0.02%
=======================================================
Files 1917 1917
Lines 190324 190325 +1
=======================================================
+ Hits 146578 146619 +41
+ Misses 43746 43706 -40 |
@SplitInfinity merged this pull request in 24ff92f. |
This pull request has been reverted by 36828aa. |
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Pull Request resolved: pytorch#56173 * Create `InplaceConverter` and `ValueTracker` to keep track of aliases of values throughout the graph. For a given value, a new alias is created every time when there is an inplace operation, SetAttr, or through nested blocks owned by If/Loop nodes. * Fix bug where controlflow node output types are not set, when the complete node is unable to run ONNX shape inference due to containing non-onnx node. * Add symbolic for `__not__` ~~and `prim_min`~~(update: moved to a separate PR), and update `index_put` opset9 to support case of assignment without providing indices. * Bump ORT version in CI test. Test Plan: Imported from OSS Reviewed By: pbelevich Differential Revision: D27866138 Pulled By: SplitInfinity fbshipit-source-id: ab5c9188740c50f783ceba4d54fda43c26e2fde7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
[ONNX] Redesign inplace conversion (#55033) #56173 [ONNX] Redesign inplace conversion ([ONNX] Redesign inplace conversion #55033)
Add standardOps match more input type in ORT (#53813) #56172 Add standardOps match more input type in ORT (Add standardOps match more input type in ORT #53813)
[ONNX] Fix ComputeShapeFromReshape when input_shape_size < reshape_size #56171 [ONNX] Fix ComputeShapeFromReshape when input_shape_size < reshape_size
[ONNX] enable word_language_model GRU and LSTM scripting (#54310) #56170 [ONNX] enable word_language_model GRU and LSTM scripting ([ONNX] enable word_language_model GRU and LSTM scripting #54310)
[ONNX] Export mv op (#55470) #56169 [ONNX] Export mv op ([ONNX] Export mv op #55470)
[ONNX] Add support for prim::min (#55259) #56168 [ONNX] Add support for prim::min ([ONNX] Add support for prim::min #55259)
Fix onnx/constant_fold.cpp compilation on Windows (#55770) #56167 Fix onnx/constant_fold.cpp compilation on Windows ([ONNX] Fix onnx/constant_fold.cpp compilation on Windows #55770)
[ONNX] Enable tensordot symbolic function. (#55654) #56166 [ONNX] Enable tensordot symbolic function. ([ONNX] Enable tensordot symbolic function. #55654)
[ONNX] Update repeat_interleave symbolic (#54312) #56165 [ONNX] Update repeat_interleave symbolic ([ONNX] Update repeat_interleave symbolic #54312)
[ONNX] Fix assign input shape for tuple inputs & primitive type inputs (#54112) #56164 [ONNX] Fix assign input shape for tuple inputs & primitive type inputs ([ONNX] Fix assign input shape for tuple inputs & primitive type inputs #54112)
[ONNX] Add support for hann_window operator. (#54587) #56163 [ONNX] Add support for hann_window operator. ([ONNX] Add support for hann_window operator. #54587)
Create
InplaceConverter
andValueTracker
to keep track of aliases of values throughout the graph. For a given value, a new alias is created every time when there is an inplace operation, SetAttr, or through nested blocks owned by If/Loop nodes.Fix bug where controlflow node output types are not set, when the complete node is unable to run ONNX shape inference due to containing non-onnx node.
Add symbolic for
__not__
and(update: moved to a separate PR), and updateprim_min
index_put
opset9 to support case of assignment without providing indices.Bump ORT version in CI test.
Differential Revision: D27866138