Alias torch.diagonal, torch.diagflat #5622
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3213
This adds
torch.diagonal
andtorch.diagflat
(like in numpy) to solve the problem thattorch.diag
is unintuitive to users and performs two functions. The implementations oftorch.diagonal
andtorch.diagflat
just calltorch.diag
.I'm not sure if this is the best idea to solve the problem of
torch.diag
being weird to users because this does complicate the API (with this change, there will be 3 diag functions). If we think this is a good idea, I'll add some quick sanity tests to test_torch and test_cuda to check thattorch.diagonal
andtorch.diagflat
do what they're supposed to.cc @gchanan @colesbury