-
Notifications
You must be signed in to change notification settings - Fork 22.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NNC] Added matmul for NNC lowering/unified dtypes #56456
Conversation
[ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 88c77cc (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages: pytorch_windows_vs2019_py36_cuda10.1_test1 (1/1)Step: "Test" (full log | diagnosis details | 🔁 rerun)
|
ghstack-source-id: fa880c7195a2881d2ba7d48eb6792a8aef9f08da Pull Request resolved: #56456
[ghstack-poisoned]
ghstack-source-id: 13e72b9c9d4c42d488b1d20af40f9918dd859d56 Pull Request resolved: #56456
[ghstack-poisoned]
ghstack-source-id: 9a49cc9f14e8515770bb47616878a719fad36bfb Pull Request resolved: #56456
[ghstack-poisoned]
ghstack-source-id: c184315270675c09531729c0e218b8bece0d8375 Pull Request resolved: #56456
[ghstack-poisoned]
ghstack-source-id: 781d73f88440e49d02be63a82d542c955444afb4 Pull Request resolved: pytorch#56456
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! Please include a more detailed description in the commit message and add a tag ([NNC] or [TensorExpr]) - it helps to find relevant commits for release notes.
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Differential Revision: [D27977532](https://our.internmc.facebook.com/intern/diff/D27977532) [ghstack-poisoned]
Summary: Pull Request resolved: pytorch#56456 Test Plan: Imported from OSS Reviewed By: ZolotukhinM Differential Revision: D27977532 Pulled By: Chillee fbshipit-source-id: c04372d988c8ef795f27037348a155894c2eddad
Stack from ghstack:
Differential Revision: D27977532