Fix broadcasting of cdist backward #56605
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 03ea991 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
ngimel
reviewed
Apr 21, 2021
ngimel
approved these changes
Apr 21, 2021
|
hm, test_variant_consistency still fails with wrong size gradients. |
|
Yes I didn't run the cuda tests locally, so I was expecting something like that... |
Fix #55370 [ghstack-poisoned]
|
@ngimel updated this PR and the one above to fix also the CUDA implementation that was suffering from similar issues. |
|
Looks good, let's see what tests say. |
|
ci is good! :) |
Fix #55370 Differential Revision: [D27939202](https://our.internmc.facebook.com/intern/diff/D27939202) [ghstack-poisoned]
Fix #55370 Differential Revision: [D27939202](https://our.internmc.facebook.com/intern/diff/D27939202) [ghstack-poisoned]
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Pull Request resolved: pytorch#56605 Fix pytorch#55370 Test Plan: Imported from OSS Reviewed By: ailzhang Differential Revision: D27939202 Pulled By: albanD fbshipit-source-id: a4ac50a7b504c24f47f5343414fb57523546a0c7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #55370
Stack from ghstack:
Differential Revision: D27939202