-
Notifications
You must be signed in to change notification settings - Fork 22.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update compare_set docs #57203
Closed
Closed
Update compare_set docs #57203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
H-Huang
requested review from
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma,
wayi1 and
zhaojuanmao
as code owners
April 28, 2021 22:13
This was referenced Apr 28, 2021
facebook-github-bot
added
oncall: distributed
Add this issue/PR to distributed oncall triage queue
cla signed
labels
Apr 28, 2021
💊 CI failures summary and remediationsAs of commit 5674299 (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages: pytorch_xla_linux_bionic_py3_6_clang9_build (1/2)Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)
|
H-Huang
added a commit
that referenced
this pull request
Apr 28, 2021
ghstack-source-id: bb887b7ff8d11d98a03df6897fbfc8872d5edd2f Pull Request resolved: #57203
cbalioglu
approved these changes
Apr 29, 2021
Update documentation to remove warning. Refactored arguments from `old_value` -> `expected_value` and `new_value` -> `desired_value` Differential Revision: [D28076556](https://our.internmc.facebook.com/intern/diff/D28076556) [ghstack-poisoned]
H-Huang
added a commit
that referenced
this pull request
Apr 29, 2021
ghstack-source-id: 215166846920fb22b1f19ce964168ff98cd21bbf Pull Request resolved: #57203
Update documentation to remove warning. Refactored arguments from `old_value` -> `expected_value` and `new_value` -> `desired_value` Differential Revision: [D28076556](https://our.internmc.facebook.com/intern/diff/D28076556) [ghstack-poisoned]
Update documentation to remove warning. Refactored arguments from `old_value` -> `expected_value` and `new_value` -> `desired_value` Differential Revision: [D28076556](https://our.internmc.facebook.com/intern/diff/D28076556) [ghstack-poisoned]
H-Huang
added a commit
that referenced
this pull request
Apr 29, 2021
ghstack-source-id: 0ac70c02e046116f655bb1220654e5aa055d13eb Pull Request resolved: #57203
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Pull Request resolved: pytorch#57203 Update documentation to remove warning. Refactored arguments from `old_value` -> `expected_value` and `new_value` -> `desired_value` Test Plan: Imported from OSS Reviewed By: gchanan, cbalioglu Differential Revision: D28076556 Pulled By: H-Huang fbshipit-source-id: 5fcc5bcfff89cad51d8dc0b74a234964f1af20ed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Update documentation to remove warning. Refactored arguments from
old_value
->expected_value
andnew_value
->desired_value
Differential Revision: D28076556