Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compare_set docs #57203

Closed
wants to merge 4 commits into from
Closed

Conversation

H-Huang
Copy link
Member

@H-Huang H-Huang commented Apr 28, 2021

Stack from ghstack:

Update documentation to remove warning. Refactored arguments from old_value -> expected_value and new_value -> desired_value

Differential Revision: D28076556

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 28, 2021

💊 CI failures summary and remediations

As of commit 5674299 (more details on the Dr. CI page):


  • 2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_build (1/2)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.
HEAD is now at 5674299d82 Update on "Update compare_set docs"
+ git merge --allow-unrelated-histories --no-edit --no-ff 95f393f212946df67350f5a20b60b82789c30684
Auto-merging torch/lib/c10d/test/HashStoreTest.cpp
CONFLICT (content): Merge conflict in torch/lib/c10d/test/HashStoreTest.cpp
Auto-merging torch/lib/c10d/test/FileStoreTest.cpp
CONFLICT (content): Merge conflict in torch/lib/c10d/test/FileStoreTest.cpp
Auto-merging torch/csrc/distributed/c10d/init.cpp
CONFLICT (content): Merge conflict in torch/csrc/distributed/c10d/init.cpp
Auto-merging torch/_C/_distributed_c10d.pyi
CONFLICT (content): Merge conflict in torch/_C/_distributed_c10d.pyi
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_build (2/2)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.
HEAD is now at 5674299d82 Update on "Update compare_set docs"
+ git merge --allow-unrelated-histories --no-edit --no-ff 95f393f212946df67350f5a20b60b82789c30684
Auto-merging torch/lib/c10d/test/HashStoreTest.cpp
CONFLICT (content): Merge conflict in torch/lib/c10d/test/HashStoreTest.cpp
Auto-merging torch/lib/c10d/test/FileStoreTest.cpp
CONFLICT (content): Merge conflict in torch/lib/c10d/test/FileStoreTest.cpp
Auto-merging torch/csrc/distributed/c10d/init.cpp
CONFLICT (content): Merge conflict in torch/csrc/distributed/c10d/init.cpp
Auto-merging torch/_C/_distributed_c10d.pyi
CONFLICT (content): Merge conflict in torch/_C/_distributed_c10d.pyi
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

H-Huang added a commit that referenced this pull request Apr 28, 2021
ghstack-source-id: bb887b7ff8d11d98a03df6897fbfc8872d5edd2f
Pull Request resolved: #57203
@H-Huang H-Huang requested a review from cbalioglu April 28, 2021 22:17
Update documentation to remove warning. Refactored arguments from `old_value` -> `expected_value` and `new_value` -> `desired_value`

Differential Revision: [D28076556](https://our.internmc.facebook.com/intern/diff/D28076556)

[ghstack-poisoned]
H-Huang added a commit that referenced this pull request Apr 29, 2021
ghstack-source-id: 215166846920fb22b1f19ce964168ff98cd21bbf
Pull Request resolved: #57203
Update documentation to remove warning. Refactored arguments from `old_value` -> `expected_value` and `new_value` -> `desired_value`

Differential Revision: [D28076556](https://our.internmc.facebook.com/intern/diff/D28076556)

[ghstack-poisoned]
Update documentation to remove warning. Refactored arguments from `old_value` -> `expected_value` and `new_value` -> `desired_value`

Differential Revision: [D28076556](https://our.internmc.facebook.com/intern/diff/D28076556)

[ghstack-poisoned]
H-Huang added a commit that referenced this pull request Apr 29, 2021
ghstack-source-id: 0ac70c02e046116f655bb1220654e5aa055d13eb
Pull Request resolved: #57203
@facebook-github-bot
Copy link
Contributor

@H-Huang merged this pull request in 149000c.

@facebook-github-bot facebook-github-bot deleted the gh/H-Huang/22/head branch May 3, 2021 14:16
krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
Summary:
Pull Request resolved: pytorch#57203

Update documentation to remove warning. Refactored arguments from `old_value` -> `expected_value` and `new_value` -> `desired_value`

Test Plan: Imported from OSS

Reviewed By: gchanan, cbalioglu

Differential Revision: D28076556

Pulled By: H-Huang

fbshipit-source-id: 5fcc5bcfff89cad51d8dc0b74a234964f1af20ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged oncall: distributed Add this issue/PR to distributed oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants