Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TensorExpr] Remove dtype_ and add buf_ fields to CodeGen::BufferArg. #57382

Closed
wants to merge 2 commits into from

Commits on Apr 30, 2021

  1. [TensorExpr] Remove dtype_ and add buf_ fields to `CodeGen::Buffe…

    …rArg`.
    
    `BufferArg` is used to describe parameters passed to the codegen: it
    indicates whether the parameter is a var or a buf and holds a pointer to
    the corresponding var/buf. Both var and buf contain dtype, and thus
    duplicating it in BufferArg is unnecessary - we can always get it from
    the var/buf. Hence we're removing dtype_ field from BufferArg in this
    PR. We're also adding a `buf_` field here: this is done so that
    BufferArg truly has all the info about the parameter.
    
    [ghstack-poisoned]
    Mikhail Zolotukhin committed Apr 30, 2021
    Copy the full SHA
    0aabfb0 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2021

  1. Update on "[TensorExpr] Remove dtype_ and add buf_ fields to `Cod…

    …eGen::BufferArg`."
    
    `BufferArg` is used to describe parameters passed to the codegen: it
    indicates whether the parameter is a var or a buf and holds a pointer to
    the corresponding var/buf. Both var and buf contain dtype, and thus
    duplicating it in BufferArg is unnecessary - we can always get it from
    the var/buf. Hence we're removing dtype_ field from BufferArg in this
    PR. We're also adding a `buf_` field here: this is done so that
    BufferArg truly has all the info about the parameter.
    
    Differential Revision: [D28128329](https://our.internmc.facebook.com/intern/diff/D28128329)
    
    [ghstack-poisoned]
    Mikhail Zolotukhin committed May 3, 2021
    Copy the full SHA
    f81f2a4 View commit details
    Browse the repository at this point in the history