[TensorExpr] Remove dtype_ and add buf_ fields to CodeGen::BufferArg.
#57382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rArg`. `BufferArg` is used to describe parameters passed to the codegen: it indicates whether the parameter is a var or a buf and holds a pointer to the corresponding var/buf. Both var and buf contain dtype, and thus duplicating it in BufferArg is unnecessary - we can always get it from the var/buf. Hence we're removing dtype_ field from BufferArg in this PR. We're also adding a `buf_` field here: this is done so that BufferArg truly has all the info about the parameter. [ghstack-poisoned]
This was referenced Apr 30, 2021
facebook-github-bot
added
the
oncall: jit
💊 CI failures summary and remediationsAs of commit f81f2a4 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
 pytorch_linux_xenial_py3_6_gcc5_4_test |
Run tests | 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group.
dgl-intel
pushed a commit
to dgl-intel/pytorch
that referenced
this pull request
Apr 30, 2021
…rArg`. `BufferArg` is used to describe parameters passed to the codegen: it indicates whether the parameter is a var or a buf and holds a pointer to the corresponding var/buf. Both var and buf contain dtype, and thus duplicating it in BufferArg is unnecessary - we can always get it from the var/buf. Hence we're removing dtype_ field from BufferArg in this PR. We're also adding a `buf_` field here: this is done so that BufferArg truly has all the info about the parameter. ghstack-source-id: e9e9ff2 Pull Request resolved: pytorch#57382
bertmaher
approved these changes
Apr 30, 2021
…eGen::BufferArg`." `BufferArg` is used to describe parameters passed to the codegen: it indicates whether the parameter is a var or a buf and holds a pointer to the corresponding var/buf. Both var and buf contain dtype, and thus duplicating it in BufferArg is unnecessary - we can always get it from the var/buf. Hence we're removing dtype_ field from BufferArg in this PR. We're also adding a `buf_` field here: this is done so that BufferArg truly has all the info about the parameter. Differential Revision: [D28128329](https://our.internmc.facebook.com/intern/diff/D28128329) [ghstack-poisoned]
|
@ZolotukhinM merged this pull request in 030692c. |
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
…rArg`. (pytorch#57382) Summary: Pull Request resolved: pytorch#57382 `BufferArg` is used to describe parameters passed to the codegen: it indicates whether the parameter is a var or a buf and holds a pointer to the corresponding var/buf. Both var and buf contain dtype, and thus duplicating it in BufferArg is unnecessary - we can always get it from the var/buf. Hence we're removing dtype_ field from BufferArg in this PR. We're also adding a `buf_` field here: this is done so that BufferArg truly has all the info about the parameter. Test Plan: Imported from OSS Reviewed By: bertmaher Differential Revision: D28128329 Pulled By: ZolotukhinM fbshipit-source-id: c03bff54bc6860f7ac6edfcb42ce6a82d8309589
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
TensorExprKernel. #57074 [TensorExpr] Add methods for inspecting generated code inTensorExprKernel.dtype_and addbuf_fields toCodeGen::BufferArg. #57382 [TensorExpr] Removedtype_and addbuf_fields toCodeGen::BufferArg.BufferArgis used to describe parameters passed to the codegen: itindicates whether the parameter is a var or a buf and holds a pointer to
the corresponding var/buf. Both var and buf contain dtype, and thus
duplicating it in BufferArg is unnecessary - we can always get it from
the var/buf. Hence we're removing dtype_ field from BufferArg in this
PR. We're also adding a
buf_field here: this is done so thatBufferArg truly has all the info about the parameter.
Differential Revision: D28128329