Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added minor fixes to Az DevOps Build Logic #59016

Closed
wants to merge 2 commits into from

Conversation

mstfbl
Copy link
Collaborator

@mstfbl mstfbl commented May 26, 2021

This PR also adds a a few minor logic changes to the custom PyTorch PR tests logic.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 26, 2021

💊 CI failures summary and remediations

As of commit 3b89251 (more details on the Dr. CI page):


  • 2/2 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build Windows CI (pytorch-win-vs2019-cpu-py3) / test (1/1)

Step: "Store PyTorch Test Reports" (full log | diagnosis details | 🔁 rerun)

2021-05-26T21:22:24.3022985Z test_add_done_ca...arg() takes 0 positional arguments but 1 was given
2021-05-26T21:22:24.2979118Z   c:\jenkins\miniconda3\lib\site-packages\coverage\cmdline.py(746): do_run
2021-05-26T21:22:24.2979841Z   c:\jenkins\miniconda3\lib\site-packages\coverage\cmdline.py(588): command_line
2021-05-26T21:22:24.2980650Z   c:\jenkins\miniconda3\lib\site-packages\coverage\cmdline.py(871): main
2021-05-26T21:22:24.2981315Z   C:\Jenkins\Miniconda3\Scripts\coverage.exe\__main__.py(7): <module>
2021-05-26T21:22:24.2982309Z   c:\jenkins\miniconda3\lib\runpy.py(85): _run_code
2021-05-26T21:22:24.2982831Z   c:\jenkins\miniconda3\lib\runpy.py(193): _run_module_as_main
2021-05-26T21:22:24.2983156Z 
2021-05-26T21:22:24.2983584Z Couldn't download test skip set, leaving all tests enabled...
2021-05-26T21:22:24.2984004Z ok (1.053s)
2021-05-26T21:22:24.3008866Z   test_add_done_callback_maintains_callback_order (__main__.TestFuture) ... ok (0.000s)
2021-05-26T21:22:24.3022985Z   test_add_done_callback_no_arg_error_is_ignored (__main__.TestFuture) ... [E pybind_utils.h:200] Got the following error when running the callback: TypeError: no_arg() takes 0 positional arguments but 1 was given
2021-05-26T21:22:24.3023781Z ok (0.000s)
2021-05-26T21:22:24.3049391Z   test_add_done_callback_simple (__main__.TestFuture) ... ok (0.016s)
2021-05-26T21:22:24.3104244Z   test_chained_then (__main__.TestFuture) ... ok (0.000s)
2021-05-26T21:22:24.4162445Z   test_collect_all (__main__.TestFuture) ... ok (0.112s)
2021-05-26T21:22:24.4182843Z   test_done (__main__.TestFuture) ... ok (0.000s)
2021-05-26T21:22:24.4213616Z   test_done_exception (__main__.TestFuture) ... ok (0.000s)
2021-05-26T21:22:24.4251763Z   test_interleaving_then_and_add_done_callback_maintains_callback_order (__main__.TestFuture) ... ok (0.000s)
2021-05-26T21:22:24.4276312Z   test_interleaving_then_and_add_done_callback_propagates_error (__main__.TestFuture) ... [E pybind_utils.h:200] Got the following error when running the callback: ValueError: Expected error
2021-05-26T21:22:24.4277060Z 
2021-05-26T21:22:24.4277315Z At:

1 failure not recognized by patterns:

Job Step Action
GitHub Actions Windows CI (pytorch-win-vs2019-cpu-py3) / render_test_results Unknown 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@mstfbl mstfbl added the module: ci Related to continuous integration label May 26, 2021
@mstfbl mstfbl force-pushed the ameliorate_devops_pr_builds branch from 8a3628c to 3b89251 Compare May 26, 2021 19:42
@anjali411 anjali411 requested a review from malfet May 26, 2021 19:55
@anjali411 anjali411 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 26, 2021
@facebook-github-bot
Copy link
Contributor

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@malfet merged this pull request in c6c563f.

deniskokarev pushed a commit to deniskokarev/pytorch that referenced this pull request Jun 9, 2021
Summary:
This PR also adds a a few minor logic changes to the custom PyTorch PR tests logic.

Pull Request resolved: pytorch#59016

Reviewed By: mrshenli

Differential Revision: D28732437

Pulled By: malfet

fbshipit-source-id: 14b7ed837209d77e0e175d92959aeb0f086e6737
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged module: ci Related to continuous integration open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants