Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unsupported attribute checker pass for torch.jit.trace #60200

Closed

Conversation

tugsbayasgalan
Copy link
Contributor

@tugsbayasgalan tugsbayasgalan commented Jun 17, 2021

Stack from ghstack:

Differential Revision: D29207583

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 17, 2021

💊 CI failures summary and remediations

As of commit 10f2863 (more details on the Dr. CI page and at hud.pytorch.org/pr/60200):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

tugsbayasgalan added a commit that referenced this pull request Jun 17, 2021
ghstack-source-id: 2bb6b6190cde76bac4c251e7a7a00ebac13c1ed3
Pull Request resolved: #60200
Copy link

@ansley ansley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if all tests end up passing

@tugsbayasgalan
Copy link
Contributor Author

@tugsbayasgalan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jun 17, 2021
@facebook-github-bot
Copy link
Contributor

@tugsbayasgalan merged this pull request in f66b53e.

@facebook-github-bot facebook-github-bot deleted the gh/tugsbayasgalan/43/head branch June 25, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants