Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused sample input argument from functions to resolve issue #55737 #60486

Closed
wants to merge 1 commit into from

Conversation

NivekT
Copy link
Contributor

@NivekT NivekT commented Jun 22, 2021

Stack from ghstack:

Differential Revision: D29311875

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 22, 2021

💊 CI failures summary and remediations

As of commit 2800ffa (more details on the Dr. CI page and at hud.pytorch.org/pr/60486):


  • 4/5 failures possibly* introduced in this PR
    • 1/4 non-scanned failure(s)
  • 1/5 broken upstream at merge base 0d2a936 on Jun 22 from 10:38am to 11:04am

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build Lint / mypy (1/2)

Step: "Run mypy" (full log | diagnosis details | 🔁 rerun)

2021-06-22T20:44:13.4580100Z torch/utils/benchm...ction "median" in typed context [no-untyped-call]
2021-06-22T20:43:59.7271016Z env:
2021-06-22T20:43:59.7271505Z   pythonLocation: /opt/hostedtoolcache/Python/3.8.10/x64
2021-06-22T20:43:59.7272134Z   LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.8.10/x64/lib
2021-06-22T20:43:59.7272621Z ##[endgroup]
2021-06-22T20:43:59.7341901Z + for CONFIG in mypy*.ini
2021-06-22T20:43:59.7344129Z + mypy --config=mypy-strict.ini
2021-06-22T20:44:11.4449136Z torch/utils/benchmark/utils/common.py:166:34: error: Call to untyped function "median" in typed context  [no-untyped-call]
2021-06-22T20:44:11.4450368Z torch/utils/benchmark/utils/common.py:168:31: error: Call to untyped function "percentile" in typed context  [no-untyped-call]
2021-06-22T20:44:11.4451651Z torch/utils/benchmark/utils/common.py:169:31: error: Call to untyped function "percentile" in typed context  [no-untyped-call]
2021-06-22T20:44:11.4452786Z torch/utils/benchmark/utils/common.py:281:18: error: Call to untyped function "round" in typed context  [no-untyped-call]
2021-06-22T20:44:13.4580100Z torch/utils/benchmark/utils/timer.py:304:24: error: Call to untyped function "median" in typed context  [no-untyped-call]
2021-06-22T20:44:17.6393858Z Found 5 errors in 2 files (checked 141 source files)
2021-06-22T20:44:18.3752282Z ##[error]Process completed with exit code 1.
2021-06-22T20:44:18.3847943Z Post job cleanup.
2021-06-22T20:44:18.4891819Z [command]/usr/bin/git version
2021-06-22T20:44:18.4946529Z git version 2.32.0
2021-06-22T20:44:18.4987821Z [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand
2021-06-22T20:44:18.5020025Z [command]/usr/bin/git submodule foreach --recursive git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :
2021-06-22T20:44:18.5276418Z [command]/usr/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
2021-06-22T20:44:18.5309900Z http.https://github.com/.extraheader
2021-06-22T20:44:18.5319092Z [command]/usr/bin/git config --local --unset-all http.https://github.com/.extraheader

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_test (2/2)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jun 22 22:05:35 AssertionError: False is not tr... was 1.0 (1.0 vs. 0.0), which occurred at index 0.
Jun 22 22:05:35 ----------------------------------------------------------------------
Jun 22 22:05:35 Traceback (most recent call last):
Jun 22 22:05:35   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 397, in instantiated_test
Jun 22 22:05:35     result = test_fn(self, *args)
Jun 22 22:05:35   File "/var/lib/jenkins/workspace/xla/test/../../test/test_view_ops.py", line 458, in test_transpose_inplace_view
Jun 22 22:05:35     self.assertEqual(t[1, 0], v[0, 1])
Jun 22 22:05:35   File "/var/lib/jenkins/workspace/xla/test/pytorch_test_base.py", line 605, in assertEqual
Jun 22 22:05:35     return DeviceTypeTestBase.assertEqual(self, x, y, *args, **kwargs)
Jun 22 22:05:35   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 1407, in assertEqual
Jun 22 22:05:35     super().assertTrue(result, msg=self._get_assert_msg(msg, debug_msg=debug_msg))
Jun 22 22:05:35 AssertionError: False is not true : Tensors failed to compare as equal!With rtol=0.001 and atol=0.001, found 1 element(s) (out of 1) whose difference(s) exceeded the margin of error (including 0 nan comparisons). The greatest difference was 1.0 (1.0 vs. 0.0), which occurred at index 0.
Jun 22 22:05:35 
Jun 22 22:05:36 ----------------------------------------------------------------------
Jun 22 22:05:36 Ran 138 tests in 4.125s
Jun 22 22:05:36 
Jun 22 22:05:36 FAILED (failures=2, skipped=102)
Jun 22 22:05:36 
Jun 22 22:05:36 Generating XML reports...
Jun 22 22:05:36 Generated XML report: test-reports/python-unittest/test.......test.test_view_ops/TEST-TestViewOpsXLA-20210622220531.xml
Jun 22 22:05:36 + cleanup
Jun 22 22:05:36 + retcode=1

1 failure not recognized by patterns:

Job Step Action
GitHub Actions Lint / quick-checks Ensure no trailing spaces 🔁 rerun

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

NivekT added a commit that referenced this pull request Jun 22, 2021
ghstack-source-id: ab09fcc83a81ee7cdaa6f39b4872322529e9e84b
Pull Request resolved: #60486
@NivekT NivekT changed the title Remove unused sample input argument from functions Remove unused sample input argument from functions to resolve issue #55737 Jun 22, 2021
@NivekT NivekT requested a review from bdhirsh June 22, 2021 20:45
@NivekT NivekT self-assigned this Jun 22, 2021
@NivekT
Copy link
Contributor Author

NivekT commented Jun 22, 2021

@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@NivekT merged this pull request in a2525b0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants