Restore LayerNorm numerics test #64385
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was deleted in #63276. The numerics test was meant to check LayerNorm behavior on large inputs, but we deleted it without realizing that. Test Plan: - wait for tests. [ghstack-poisoned]
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit bee6ede (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
ngimel
approved these changes
Sep 1, 2021
krshrimali
approved these changes
Sep 1, 2021
Codecov Report
@@ Coverage Diff @@
## gh/zou3519/380/base #64385 +/- ##
=======================================================
+ Coverage 64.62% 66.71% +2.08%
=======================================================
Files 705 705
Lines 92159 92215 +56
=======================================================
+ Hits 59559 61521 +1962
+ Misses 32600 30694 -1906 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
It was deleted in #63276.
The numerics test was meant to check LayerNorm behavior on large inputs,
but we deleted it without realizing that.
Test Plan:
Differential Revision: D30702950