[FSDP] No need for list() in _get_shard #66957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunk appears to return a tuple which is enough given that we just index to the right chunk and discard the rest. Differential Revision: [D31780799](https://our.internmc.facebook.com/intern/diff/D31780799/) [ghstack-poisoned]
rohan-varma
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87 and
zhaojuanmao
as code owners
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 0961f98 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: distributed
This was referenced Oct 20, 2021
zhaojuanmao
approved these changes
Oct 20, 2021
There was a problem hiding this comment.
thanks! but could we land these changes after #66904 is landed, so that we have more tests to catch regression?
|
Yes, will wait for unittest changes to be landed. |
chunk appears to return a tuple which is enough given that we just index to the right chunk and discard the rest. Differential Revision: [D31780799](https://our.internmc.facebook.com/intern/diff/D31780799/) [ghstack-poisoned]
chunk appears to return a tuple which is enough given that we just index to the right chunk and discard the rest. Differential Revision: [D31780799](https://our.internmc.facebook.com/intern/diff/D31780799/) [ghstack-poisoned]
chunk appears to return a tuple which is enough given that we just index to the right chunk and discard the rest. Differential Revision: [D31780799](https://our.internmc.facebook.com/intern/diff/D31780799/) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 24, 2021
Summary: Pull Request resolved: #66957 chunk appears to return a tuple which is enough given that we just index to the right chunk and discard the rest. ghstack-source-id: 141391149 Test Plan: CI Reviewed By: mrshenli Differential Revision: D31780799 fbshipit-source-id: fdb1b77fffa916328e14a4cd692b5241ae46a514
langong347
pushed a commit
that referenced
this pull request
Oct 25, 2021
Summary: Pull Request resolved: #66957 chunk appears to return a tuple which is enough given that we just index to the right chunk and discard the rest. ghstack-source-id: 141391149 Test Plan: CI Reviewed By: mrshenli Differential Revision: D31780799 fbshipit-source-id: fdb1b77fffa916328e14a4cd692b5241ae46a514
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
chunk appears to return a tuple which is enough given that we just
index to the right chunk and discard the rest.
Differential Revision: D31780799