OpInfos for torch.atleast_{1d, 2d, 3d} #67355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit fa70996 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
[ghstack-poisoned]
[ghstack-poisoned]
anjali411
added a commit
that referenced
this pull request
Oct 27, 2021
ghstack-source-id: 2fc773fc8033b68f9d89c9b17a29dfffaf3560d2 Pull Request resolved: #67355
mruberry
reviewed
Oct 27, 2021
| input_list.append(make_tensor_partial(shape)) | ||
| samples = [ | ||
| SampleInput(input_list, ), | ||
| SampleInput(torch.tensor(0, dtype=dtype, device=device, requires_grad=requires_grad),), |
There was a problem hiding this comment.
Adding more individual tensors might be easy and provide more coverage:
samples = []
input_list = []
for shape in shapes:
input_list.append(make_tensor_partial(shape))
samples.append(SampleInput(make_tensor_partial(shape)))
samples.append(SampleInput(input_list))
There was a problem hiding this comment.
yeah I was just wondering if it's actually necessary, but sure
|
@pytorchbot ciflow rerun -l ciflow/all -l ciflow/slow-gradcheck |
mruberry
approved these changes
Oct 27, 2021
|
Ug, the test failures look real and this needs those fx skips (although @Chillee is working on unifying those skips with the typical OpInfo skips now...) |
[ghstack-poisoned]
|
Looks like the functorch test will need to be skipped. How to skip that test depends, I think, on whether this goes in before or after #67520. |
|
ping @anjali411 -- I think this just needs a tweak to the skips and it's good to go |
[ghstack-poisoned]
|
@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Differential Revision: [D32649416](https://our.internmc.facebook.com/intern/diff/D32649416) [ghstack-poisoned]
|
@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@anjali411 merged this pull request in c7d5e0f. |
PaliC
added a commit
that referenced
this pull request
Nov 30, 2021
Summary: Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D32649416 Pulled By: anjali411 fbshipit-source-id: 1b42e86c7124427880fff52fbe490481059da967 [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D32649416