OpInfos for torch.{flatten, column_stack} #67555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 8be8711 (more details on the Dr. CI page):
🕵️ 9 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
anjali411
added a commit
that referenced
this pull request
Oct 29, 2021
ghstack-source-id: 6c77b217d583090c9d1530ef4624fb8d19a0f86c Pull Request resolved: #67555
mruberry
reviewed
Oct 29, 2021
mruberry
reviewed
Oct 29, 2021
| input_list = [] | ||
| cases: Tuple[tuple, tuple] = ( # type: ignore[assignment] | ||
| ((S, 2, 1), (S, 3, 1)), | ||
| ((S), (S, 5)), ((), (1, S)) |
There was a problem hiding this comment.
((S), (S, 5)) -> ((S,), (S, 5))?
mruberry
approved these changes
Oct 29, 2021
There was a problem hiding this comment.
Awesome! Just a couple inline comments for your consideration.
Thanks @anjali411!
[ghstack-poisoned]
anjali411
added a commit
that referenced
this pull request
Nov 24, 2021
ghstack-source-id: 0b86f6443cbba7fca656578f7ebe427bf465ea8d Pull Request resolved: #67555
|
@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@anjali411 merged this pull request in aceb46e. |
|
This pull request has been reverted by 14dc975. To re-land this change, follow these steps. |
PaliC
added a commit
that referenced
this pull request
Nov 30, 2021
Summary: Test Plan: Imported from OSS Reviewed By: cpuhrsch Differential Revision: D32650384 Pulled By: anjali411 fbshipit-source-id: 9ead83b378d0ece60569e1a0fc7d8849f89566b3 [ghstack-poisoned]
|
This pull request has been reverted by 14dc975. To re-land this change, follow these steps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D32650384