Fix DLPack CUDA stream convention #67618
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit c4494d0 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
emcastillo
force-pushed
the
fix-dlpack
branch
from
f1eabae
to
f42295b
Compare
leofang
suggested changes
Nov 1, 2021
emcastillo
force-pushed
the
fix-dlpack
branch
2 times, most recently
from
06a8985
to
8114b16
Compare
mruberry
added
the
triaged
rgommers
approved these changes
Nov 2, 2021
|
Hey @emcastillo! Thanks for this fix and your patience (I was moving from the West Coast to the East Coast)! It looks like the ROCm failure is real, however: Any idea what's going on there? One option would be to file a follow-up issue and skip the test on ROCm for now (with a link to the issue). |
Stream numbering for CUDA and ROCm is different, it's I have a vague memory about us talking about this before, and there being an issue with detecting whether we're running on ROCm, but I can't find it back. |
|
Thanks @mruberry, ler me take a closer look and fix it! |
emcastillo
force-pushed
the
fix-dlpack
branch
from
b72a634
to
c4494d0
Compare
|
@mruberry all tests passed :) |
|
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
mruberry
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently for the array API, cuda default stream and per thread stream should be 1 and 2 instead of 0 and 1:
https://data-apis.org/array-api/latest/API_specification/array_object.html?dlpack-self-stream-none#dlpack-self-stream-none.
This caused a problem in the interop with CuPy cupy/cupy#5970 (comment).
cc @rgommers @leofang @mruberry