Fix conv_transpose3d backward with non-contiguous grad_out #67829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-vi
requested review from
albanD,
IvanYashchuk,
lezcano,
nikitaved and
soulitzer
as code owners
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 5be632d (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
t-vi
force-pushed
the
conv3d_backward_cpu
branch
from
ee3f576
to
78c3440
Compare
Many thanks to Forest Yang (meowmix) from the forum for reporting it with a minimal reproduction.
|
I forgot to add: The equivalent 2d fix is #33462 . |
albanD
approved these changes
Nov 4, 2021
There was a problem hiding this comment.
Sounds good.
Can you rebase on top of master for the CI to run please?
cc @jbschlosser FYI to make sure not to regress in the conv refactor.
t-vi
force-pushed
the
conv3d_backward_cpu
branch
from
78c3440
to
5be632d
Compare
|
@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks to Forest Yang (meowmix) from the forum for reporting it with a minimal reproduction.