Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug positive definite constraints #68720

Closed
wants to merge 54 commits into from
Closed

Debug positive definite constraints #68720

wants to merge 54 commits into from

Commits on Nov 19, 2021

  1. Added 'torch.distributions.constraints.symmetric' checking if the ten… 

    …sor is symmetric in last 2 dimensions.
    @nonconvexopt
    nonconvexopt committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    3d1567a View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2021

  1. Fit flake8 requirements

    @nonconvexopt
    nonconvexopt committed Nov 20, 2021
    Configuration menu
    Copy the full SHA
    265759c View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2021

  1. Disabled calling symmetric class and postive definite class in Public… 

    … interface.
    @nonconvexopt
    nonconvexopt committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    909af85 View commit details
    Browse the repository at this point in the history

  2. Reverted Calling classes symmetric and postivie_definite in public in… 

    …terface
    @nonconvexopt
    nonconvexopt committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    83c8b41 View commit details
    Browse the repository at this point in the history

  3. Added test for symmetric constraint and positive_definite constraint

    @nonconvexopt
    nonconvexopt committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    9b1dcda View commit details
    Browse the repository at this point in the history

  4. Fix error in positive definite constraint

    @nonconvexopt
    nonconvexopt committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    8a0cef2 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2021

  1. Improve converting complex value to real

    @nonconvexopt
    nonconvexopt committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    124fb09 View commit details
    Browse the repository at this point in the history

  2. Reflected the comment of neerajprad and cleaned argument usage for py… 

    …test.
    @nonconvexopt
    nonconvexopt committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    295a348 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'pytorch:master' into torch.distributions.constraints.sy… 

    …mmetric
    @nonconvexopt
    nonconvexopt committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    c2da8f0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'pytorch:master' into debug_positive_definite_constraints

    @nonconvexopt
    nonconvexopt committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    df3094c View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. Merge branch 'pytorch:master' into debug_positive_definite_constraints

    @nonconvexopt
    nonconvexopt committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    c0f10a4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'pytorch:master' into torch.distributions.constraints.sy… 

    …mmetric
    @nonconvexopt
    nonconvexopt committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    510f7b4 View commit details
    Browse the repository at this point in the history

  3. use torch.linalg.cholesky_ex and reflect Lezcano's feedback 

    Co-authored-by: Lezcano <Lezcano@users.noreply.github.com>
    @nonconvexopt @lezcano
    nonconvexopt and lezcano committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    61bea99 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'pytorch:master' into debug_positive_definite_constraints

    @nonconvexopt
    nonconvexopt committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    bec8072 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2021

  1. Merge branch 'pytorch:master' into debug_positive_definite_constraints

    @nonconvexopt
    nonconvexopt committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    2a6e2e4 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2021

  1. Applied inheritance among matrix constraints.

    @nonconvexopt
    nonconvexopt committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    8fc1ac2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into debug_positive_definite_constraints

    @nonconvexopt
    nonconvexopt committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    8f5a13e View commit details
    Browse the repository at this point in the history

  3. Removed trailing spaces.

    @nonconvexopt
    nonconvexopt committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    d6b9e5b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'debug_positive_definite_constraints' of github.com:nonc… 

    …onvexopt/pytorch into debug_positive_definite_constraints
    @nonconvexopt
    nonconvexopt committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    6e1c347 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'pytorch:master' into torch.distributions.constraints.sy… 

    …mmetric
    @nonconvexopt
    nonconvexopt committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    ed195fe View commit details
    Browse the repository at this point in the history

  6. Fix conflicts

    @nonconvexopt
    nonconvexopt committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    77d0895 View commit details
    Browse the repository at this point in the history

  7. Change to

    @nonconvexopt
    nonconvexopt committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    eaf5c96 View commit details
    Browse the repository at this point in the history

  8. Change 'zeros' to 'full' and reflect feedback of Lezcano. 

    Co-authored-by: Lezcano <Lezcano@users.noreply.github.com>
    @nonconvexopt @lezcano
    nonconvexopt and lezcano committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    315891d View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2021

  1. Merge branch 'pytorch:master' into debug_positive_definite_constraints

    @nonconvexopt
    nonconvexopt committed Nov 27, 2021
    Configuration menu
    Copy the full SHA
    0012075 View commit details
    Browse the repository at this point in the history

  2. Change assertion to return and give device parameter to 'torch.full' … 

    …in '_Square'
    @nonconvexopt
    nonconvexopt committed Nov 27, 2021
    Configuration menu
    Copy the full SHA
    37a6f68 View commit details
    Browse the repository at this point in the history

  3. Test CI with only positive definite checking.

    @nonconvexopt
    nonconvexopt committed Nov 27, 2021
    Configuration menu
    Copy the full SHA
    d52e0cc View commit details
    Browse the repository at this point in the history

  4. Testing CI

    @nonconvexopt
    nonconvexopt committed Nov 27, 2021
    Configuration menu
    Copy the full SHA
    46a6a15 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2021

  1. Merge branch 'pytorch:master' into debug_positive_definite_constraints

    @nonconvexopt
    nonconvexopt committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    42e87d0 View commit details
    Browse the repository at this point in the history

  2. Test CI with Symmetric and positive definite

    @nonconvexopt
    nonconvexopt committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    68a8cc2 View commit details
    Browse the repository at this point in the history

  3. Fixing CI errors.

    @nonconvexopt
    nonconvexopt committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    deefc14 View commit details
    Browse the repository at this point in the history

  4. Fixing CI errors

    @nonconvexopt
    nonconvexopt committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    676a93a View commit details
    Browse the repository at this point in the history

  5. Try torch.linalg.eigvalsh

    @nonconvexopt
    nonconvexopt committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    c3458a0 View commit details
    Browse the repository at this point in the history

  6. Fixing CI errors.

    @nonconvexopt
    nonconvexopt committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    9bd333e View commit details
    Browse the repository at this point in the history

  7. Merge branch 'pytorch:master' into debug_positive_definite_constraints

    @nonconvexopt
    nonconvexopt committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    b21b011 View commit details
    Browse the repository at this point in the history

  8. Fixing CI errors

    @nonconvexopt
    nonconvexopt committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    b28994a View commit details
    Browse the repository at this point in the history

  9. Revert modifications tried for debugging CI

    @nonconvexopt
    nonconvexopt committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    76f4d4e View commit details
    Browse the repository at this point in the history

  10. Merged pytorch#68644

    @nonconvexopt
    nonconvexopt committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    50e0329 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2021

  1. Solve TODO in 'torch.distributions.multivariate_normal'

    @nonconvexopt
    nonconvexopt committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    3aa4d89 View commit details
    Browse the repository at this point in the history

  2. Test CI wish softer check

    @nonconvexopt
    nonconvexopt committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    ebb029f View commit details
    Browse the repository at this point in the history

  3. Revert modification.

    @nonconvexopt
    nonconvexopt committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    2f9f665 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'pytorch:master' into debug_positive_definite_constraints

    @nonconvexopt
    nonconvexopt committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    369d5f8 View commit details
    Browse the repository at this point in the history

  5. Fix error in testing the positive definite constraints.

    @nonconvexopt
    nonconvexopt committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    a0d9595 View commit details
    Browse the repository at this point in the history

  6. Merge master

    @nonconvexopt
    nonconvexopt committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    8fe83da View commit details
    Browse the repository at this point in the history

  7. Fixing CI errors

    @nonconvexopt
    nonconvexopt committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    5e0f85e View commit details
    Browse the repository at this point in the history

  8. Use torch.isclose and reflect the feedback of neerajprad

    @nonconvexopt
    nonconvexopt committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    bc1c635 View commit details
    Browse the repository at this point in the history

  9. Fixing CI errors.

    @nonconvexopt
    nonconvexopt committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    0d3a4a9 View commit details
    Browse the repository at this point in the history

  10. Revert modification in '_precision_to_scale_tril' in multivariate_normal

    @nonconvexopt
    nonconvexopt committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    7adfb50 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'pytorch:master' into debug_positive_definite_constraints

    @nonconvexopt
    nonconvexopt committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    6b57d92 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2021

  1. Add test for high dimensional symmetric matrices.

    @nonconvexopt
    nonconvexopt committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    a1ceee6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'debug_positive_definite_constraints' of github.com:nonc… 

    …onvexopt/pytorch into debug_positive_definite_constraints
    @nonconvexopt
    nonconvexopt committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    3cf67b2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'pytorch:master' into debug_positive_definite_constraints

    @nonconvexopt
    nonconvexopt committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    838c288 View commit details
    Browse the repository at this point in the history

  4. Delete assert message in 'test_constraint' function

    @nonconvexopt
    nonconvexopt committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    3bd0acd View commit details
    Browse the repository at this point in the history

  5. Merge branch 'pytorch:master' into debug_positive_definite_constraints

    @nonconvexopt
    nonconvexopt committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    ee046f4 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'pytorch:master' into debug_positive_definite_constraints

    @nonconvexopt
    nonconvexopt committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    67b3448 View commit details
    Browse the repository at this point in the history