Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug positive definite constraints #68720
Debug positive definite constraints #68720
Changes from all commits
3d1567a
265759c
909af85
83c8b41
9b1dcda
8a0cef2
124fb09
295a348
c2da8f0
df3094c
c0f10a4
510f7b4
61bea99
bec8072
2a6e2e4
8fc1ac2
8f5a13e
d6b9e5b
6e1c347
ed195fe
77d0895
eaf5c96
315891d
0012075
37a6f68
d52e0cc
46a6a15
42e87d0
68a8cc2
deefc14
676a93a
c3458a0
9bd333e
b21b011
b28994a
76f4d4e
50e0329
3aa4d89
ebb029f
2f9f665
369d5f8
a0d9595
8fe83da
5e0f85e
bc1c635
0d3a4a9
7adfb50
6b57d92
a1ceee6
3cf67b2
838c288
3bd0acd
ee046f4
67b3448
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that these constructors are deprecated. The correct way of writing this code would be to pass a
device
to this function and to dotorch.tensor(data, dtype=torch.double, device=device)
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try to correct it at a new PR since we have to modify all the functions in
test/distributions/test_constraints.py
. Thanks for your feedback.