Remove backward ops for NNPACK spatial convolution #70305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit d567ee5 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@jbschlosser has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Differential Revision: [D33279223](https://our.internmc.facebook.com/intern/diff/D33279223) [ghstack-poisoned]
|
@jbschlosser has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
These backward ops are currently **unused** since the backward pass for NNPACK calls `slow_conv_dilated2d` instead. I decided to leave in the functions (not as ops) since I believe mobile may want to use them in the future, but I could be convinced to remove them entirely instead. Differential Revision: [D33279223](https://our.internmc.facebook.com/intern/diff/D33279223) [ghstack-poisoned]
|
@jbschlosser has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
zou3519
approved these changes
Dec 22, 2021
Nope, not AFAICT. There's one test in I'm happy to remove these functions. If for some reason they're needed in the future, they can be added in then. |
These backward ops are currently **unused** since the backward pass for NNPACK calls `slow_conv_dilated2d` instead. I decided to leave in the functions (not as ops) since I believe mobile may want to use them in the future, but I could be convinced to remove them entirely instead. Differential Revision: [D33279223](https://our.internmc.facebook.com/intern/diff/D33279223) [ghstack-poisoned]
jbschlosser
added a commit
that referenced
this pull request
Dec 22, 2021
ghstack-source-id: 62dbf901ffcd283034fbc3ce3b1b7945bf4e67f8 Pull Request resolved: #70305
|
@jbschlosser has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
These backward ops are currently unused since the backward pass for NNPACK calls
slow_conv_dilated2dinstead.I decided to leave in the functions (not as ops) since I believe mobile may want to use them in the future, but I could be convinced to remove them entirely instead.
Differential Revision: D33279223