Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove backward ops for NNPACK spatial convolution #70305

Closed
wants to merge 4 commits into from
Closed

Remove backward ops for NNPACK spatial convolution #70305

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1309602
Remove backward ops for NNPACK spatial convolution
jbschlosser Dec 22, 2021
9189e13
Update on "Remove backward ops for NNPACK spatial convolution"
jbschlosser Dec 22, 2021
1bda2e6
Update on "Remove backward ops for NNPACK spatial convolution"
jbschlosser Dec 22, 2021
d567ee5
Update on "Remove backward ops for NNPACK spatial convolution"
jbschlosser Dec 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions aten/src/ATen/native/NNPACK.cpp
View file
Open in desktop
Expand Up @@ -581,11 +581,11 @@ std::tuple<Tensor, Tensor, Tensor> _nnpack_spatial_convolution_backward(
std::array<bool, 3> output_mask) {
Tensor grad_input, grad_weight, grad_bias;
if (output_mask[0]) {
grad_input = at::_nnpack_spatial_convolution_backward_input(
grad_input = _nnpack_spatial_convolution_backward_input(
input, grad_output, weight, padding);
}
if (output_mask[1]) {
grad_weight = at::_nnpack_spatial_convolution_backward_weight(
grad_weight = _nnpack_spatial_convolution_backward_weight(
input, weight.sizes(), grad_output, padding);
}
if (output_mask[2]) {
Expand Down
9 changes: 0 additions & 9 deletions aten/src/ATen/native/native_functions.yaml
View file
Open in desktop
Expand Up @@ -3326,15 +3326,6 @@
dispatch:
CompositeExplicitAutograd: _nnpack_spatial_convolution

- func: _nnpack_spatial_convolution_backward(Tensor input, Tensor grad_output, Tensor weight, int[2] padding, bool[3] output_mask) -> (Tensor, Tensor, Tensor)
variants: function

- func: _nnpack_spatial_convolution_backward_input(Tensor input, Tensor grad_output, Tensor weight, int[2] padding) -> Tensor
variants: function

- func: _nnpack_spatial_convolution_backward_weight(Tensor input, int[] weightsize, Tensor grad_output, int[2] padding) -> Tensor
variants: function

- func: ones.names(int[] size, *, Dimname[]? names, ScalarType? dtype=None, Layout? layout=None, Device? device=None, bool? pin_memory=None) -> Tensor
device_check: NoCheck
device_guard: False
Expand Down
3 changes: 3 additions & 0 deletions test/backward_compatibility/check_backward_compatibility.py
View file
Open in desktop
Expand Up @@ -57,6 +57,9 @@
("aten::cudnn_convolution_transpose_backward", datetime.date(2022, 1, 31)),
("aten::cudnn_convolution_transpose_backward_input", datetime.date(2022, 1, 31)),
("aten::cudnn_convolution_transpose_backward_weight", datetime.date(2022, 1, 31)),
("aten::_nnpack_spatial_convolution_backward", datetime.date(2022, 1, 31)),
("aten::_nnpack_spatial_convolution_backward_input", datetime.date(2022, 1, 31)),
("aten::_nnpack_spatial_convolution_backward_weight", datetime.date(2022, 1, 31)),
("aten::_slow_conv2d_forward", datetime.date(2022, 1, 31)),
("aten::_slow_conv2d_backward", datetime.date(2022, 1, 31)),
("aten::slow_conv3d_forward", datetime.date(2022, 1, 31)),
Expand Down