quantization: fix scale+zp serialization of quantized BatchNorm{2|3}d #70432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Not for review yet. Scale and zero_point need to be buffers for serialization to work on them properly. For now, this PR fixes the issue without dealing with BC, just so we can run CI and see how many callsites expect the old behavior. CI results will determine next steps. Test Plan: ``` python test/test_quantization.py TestStaticQuantizedModule.test_batch_norm2d_serialization ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
vkuzo
added a commit
that referenced
this pull request
Dec 27, 2021
Summary: Not for review yet. Scale and zero_point need to be buffers for serialization to work on them properly. For now, this PR fixes the issue without dealing with BC, just so we can run CI and see how many callsites expect the old behavior. CI results will determine next steps. Test Plan: ``` python test/test_quantization.py TestStaticQuantizedModule.test_batch_norm2d_serialization ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: cdbf2362c95f4ff33547aa84cc669cb5d1dc51b1 Pull Request resolved: #70432
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 0bee19a (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
|
@vkuzo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…3}d" Summary: Not for review yet. Scale and zero_point need to be buffers for serialization to work on them properly. For now, this PR fixes the issue without dealing with BC, just so we can run CI and see how many callsites expect the old behavior. CI results will determine next steps. Test Plan: ``` python test/test_quantization.py TestStaticQuantizedModule.test_batch_norm2d_serialization ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D33330022](https://our.internmc.facebook.com/intern/diff/D33330022) [ghstack-poisoned]
vkuzo
added a commit
that referenced
this pull request
Dec 28, 2021
Summary: Not for review yet. Scale and zero_point need to be buffers for serialization to work on them properly. For now, this PR fixes the issue without dealing with BC, just so we can run CI and see how many callsites expect the old behavior. CI results will determine next steps. Test Plan: ``` python test/test_quantization.py TestStaticQuantizedModule.test_batch_norm2d_serialization ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 1308837dbdc16ababcca95f6a461372c2ae78060 Pull Request resolved: #70432
|
@vkuzo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
vkuzo
changed the title
…hNorm{2|3}d"
Summary:
Scale and zero_point need to be buffers for serialization to work
on them properly. This PR moves them to buffers. This is BC breaking,
but the "before" state was completely broken (scale + zp were not
serialized at all) so there is no value in trying to handle it.
Test Plan:
```
python test/test_quantization.py TestStaticQuantizedModule.test_batch_norm2d_serialization
python test/test_quantization.py TestStaticQuantizedModule.test_batch_norm3d_serialization
```
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: [D33330022](https://our.internmc.facebook.com/intern/diff/D33330022)
[ghstack-poisoned]
vkuzo
added a commit
that referenced
this pull request
Dec 28, 2021
Summary: Scale and zero_point need to be buffers for serialization to work on them properly. This PR moves them to buffers. This is BC breaking, but the "before" state was completely broken (scale + zp were not serialized at all) so there is no value in trying to handle it. Test Plan: ``` python test/test_quantization.py TestStaticQuantizedModule.test_batch_norm2d_serialization python test/test_quantization.py TestStaticQuantizedModule.test_batch_norm3d_serialization ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 6a3424d0f001431ca38f8ce1c6766fdee6e48f02 Pull Request resolved: #70432
|
@vkuzo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
jerryzh168
reviewed
Jan 5, 2022
| @@ -644,6 +644,50 @@ def test_batch_norm3d(self): | |||
| self.assertEqual(quant_ref.int_repr().numpy(), qy.int_repr().numpy(), | |||
| msg="BatchNorm3d module API failed") | |||
|
|
|||
| def _test_batch_norm_serialization(self, get_model, data1, data2): | |||
| m1 = get_model() | |||
| m1.qconfig = torch.quantization.default_qconfig | |||
There was a problem hiding this comment.
nit: torch.ao.quantization
…hNorm{2|3}d"
Summary:
Scale and zero_point need to be buffers for serialization to work
on them properly. This PR moves them to buffers. This is BC breaking,
but the "before" state was completely broken (scale + zp were not
serialized at all) so there is no value in trying to handle it.
Test Plan:
```
python test/test_quantization.py TestStaticQuantizedModule.test_batch_norm2d_serialization
python test/test_quantization.py TestStaticQuantizedModule.test_batch_norm3d_serialization
```
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: [D33330022](https://our.internmc.facebook.com/intern/diff/D33330022)
[ghstack-poisoned]
vkuzo
added a commit
that referenced
this pull request
Jan 5, 2022
Summary: Scale and zero_point need to be buffers for serialization to work on them properly. This PR moves them to buffers. This is BC breaking, but the "before" state was completely broken (scale + zp were not serialized at all) so there is no value in trying to handle it. Test Plan: ``` python test/test_quantization.py TestStaticQuantizedModule.test_batch_norm2d_serialization python test/test_quantization.py TestStaticQuantizedModule.test_batch_norm3d_serialization ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 1649ae2f68bd43b804f29e7fd30f5a132ee9773c Pull Request resolved: #70432
|
@vkuzo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Scale and zero_point need to be buffers for serialization to work
on them properly. This PR moves them to buffers. This is BC breaking,
but the "before" state was completely broken (scale + zp were not
serialized at all) so there is no value in trying to handle it.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D33330022