Skip failing tests in test_nn if compiled without LAPACK #70913

lithuak · 2022-01-06T12:27:29Z

pytorch-probot · 2022-01-06T12:27:32Z

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/lithuak/pytorch/blob/3333c517f82010432f8449e878ded816ff70bc5d/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default

Workflows	Labels (bold enabled)	Status
Triggered Workflows
linux-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/trunk`	✅ triggered
linux-docs	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/docs`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-vulkan-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`, `ciflow/vulkan`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-build	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-asan	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/sanitizers`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-onnx	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/onnx`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
docker-builds	`ciflow/all`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-custom-ops	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-metal	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`, `ciflow/trunk`	🚫 skipped
linux-docs-push	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
macos-10-15-py3-arm64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-11-py3-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`, `ciflow/slow`, `ciflow/slow-gradcheck`	🚫 skipped
periodic-linux-xenial-cuda11.1-py3.7-gcc7-debug	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-win-vs2019-cuda11.1-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
periodic-win-vs2019-cuda11.5-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped

You can add a comment to the PR and tag @pytorchbot with the following commands:

# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

facebook-github-bot · 2022-01-06T12:27:35Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/70913
📄 Preview docs built from this PR
📄 Preview C++ docs built from this PR
🔧 Opt-in to CIFlow to control what jobs run on your PRs

💊 CI failures summary and remediations

As of commit 3333c51 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

albanD · 2022-01-06T13:29:09Z

cc @lezcano these tests are important. We should make sure we can run them without Lapack. Should we pick a different set of functions to ensure it is true?

lithuak · 2022-01-06T13:36:58Z

@albanD I'm new to the codebase, so my proposed fix was just an improvised attempts to make it work.

One small thing that comes to mind - use @skipCPUIfNoLapack instead of @skipIfNoLapack. That would make it a bit more narrow. Not sure it solves the problem though.

albanD · 2022-01-06T14:10:07Z

No problem!
We don't have a CI build without LAPACK unfortunately as this is something that is available in the vast majority of cases. So maybe this fix is good since it doesn't change anything on the actual CI.
I just want the opinion from @lezcano on that. You can leave the PR as-is for now.

lezcano · 2022-01-07T09:42:05Z

I agree that we should use a simpler function to test this functionality that does not depend on LAPACK.

I think that this skip is fine for now given that we always use LAPACK in the CI, but it'd be good to at least leave a # FIXME comment over these tests explaining what's going on here.

albanD · 2022-01-07T14:38:12Z

Sounds good!
@lithuak could you add the #FIXME comment next the skips please and I'll land that!

lithuak · 2022-01-07T14:40:53Z

@albanD yep. I think I can also add a github issue listing those tests to be fixed WDYT

albanD · 2022-01-07T14:44:34Z

Yes, an issue is even better!

lezcano

LGTM modulo a very small nit!

test/test_nn.py

lithuak

started a review by mistake, pls ignore it

albanD

Thanks for the update!

facebook-github-bot · 2022-01-11T19:19:16Z

@albanD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Skip failing tests in test_nn if compiled w/o LAPACK

8c8eb35

pytorch-probot bot added the ciflow/default label Jan 6, 2022

facebook-github-bot added the cla signed label Jan 6, 2022

pytorchbot added the open source label Jan 6, 2022

albanD requested review from lezcano and albanD January 6, 2022 13:29

albanD added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 6, 2022

lithuak mentioned this pull request Jan 7, 2022

Rewrite tests in test_nn to not depend on LAPACK #70995

Open

5 tasks

Add FIXME for skipped tests

adc42fc

lezcano approved these changes Jan 7, 2022

View reviewed changes

test/test_nn.py Outdated Show resolved Hide resolved

UnFIXME two test

3333c51

lithuak commented Jan 7, 2022

View reviewed changes

albanD approved these changes Jan 11, 2022

View reviewed changes

facebook-github-bot closed this in a8612cd Jan 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Skip failing tests in test_nn if compiled without LAPACK #70913

Skip failing tests in test_nn if compiled without LAPACK #70913

lithuak commented Jan 6, 2022

pytorch-probot bot commented Jan 6, 2022 •

edited

Loading

⚛️ CI Flow

facebook-github-bot commented Jan 6, 2022 •

edited

Loading

albanD commented Jan 6, 2022

lithuak commented Jan 6, 2022

albanD commented Jan 6, 2022

lezcano commented Jan 7, 2022

albanD commented Jan 7, 2022

lithuak commented Jan 7, 2022 •

edited

Loading

albanD commented Jan 7, 2022

lezcano left a comment

lithuak left a comment •

edited

Loading

albanD left a comment

facebook-github-bot commented Jan 11, 2022

Skip failing tests in test_nn if compiled without LAPACK #70913

Skip failing tests in test_nn if compiled without LAPACK #70913

Conversation

lithuak commented Jan 6, 2022

pytorch-probot bot commented Jan 6, 2022 • edited Loading

⚛️ CI Flow

facebook-github-bot commented Jan 6, 2022 • edited Loading

🔗 Helpful links

💊 CI failures summary and remediations

albanD commented Jan 6, 2022

lithuak commented Jan 6, 2022

albanD commented Jan 6, 2022

lezcano commented Jan 7, 2022

albanD commented Jan 7, 2022

lithuak commented Jan 7, 2022 • edited Loading

albanD commented Jan 7, 2022

lezcano left a comment

Choose a reason for hiding this comment

lithuak left a comment • edited Loading

Choose a reason for hiding this comment

albanD left a comment

Choose a reason for hiding this comment

facebook-github-bot commented Jan 11, 2022

pytorch-probot bot commented Jan 6, 2022 •

edited

Loading

facebook-github-bot commented Jan 6, 2022 •

edited

Loading

lithuak commented Jan 7, 2022 •

edited

Loading

lithuak left a comment •

edited

Loading