Fix bug in upgrader generation in mobile #71578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit b3990b1 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
facebook-github-bot
added
oncall: jit
|
This pull request was exported from Phabricator. Differential Revision: D33690113 |
tugsbayasgalan
force-pushed
the
export-D33690113
branch
from
d919b94
to
2e8baf4
Compare
cccclai
approved these changes
Jan 20, 2022
Comment on lines
4
to
6
| namespace c10 { | ||
| TypePtr parseType(const std::string& pythonStr); | ||
| } // namespace c10 |
There was a problem hiding this comment.
Looks like these lines were missing in the codegen, could you help with adding them?
There was a problem hiding this comment.
I meant adding them as part of gen_mobile_upgraders.py
Comment on lines
+10
to
+12
| #include <ATen/core/ivalue.h> | ||
| #include <caffe2/serialize/versions.h> | ||
| #include <torch/csrc/jit/mobile/type_parser.h> |
There was a problem hiding this comment.
These headers may not be needed, if the previous version work.
| def _get_operator_version_map() -> Dict[str, List[_UpgraderEntry]]: ... | ||
|
|
||
| def _get_upgrader_ranges(name: str) -> List[_UpgraderRange]: ... |
There was a problem hiding this comment.
Thanks for creating an api for it! Very neat
| upgrader_info = list(filter(lambda token: token != "", upgrader_entry.upgrader_name.split('_'))) | ||
| upgrader_min_version = upgrader_info[2] | ||
| upgrader_max_version = upgrader_info[3] | ||
| upgrader_ranges = torch._C._get_upgrader_ranges(op_name) |
|
This pull request was exported from Phabricator. Differential Revision: D33690113 |
tugsbayasgalan
force-pushed
the
export-D33690113
branch
from
2e8baf4
to
b5174c2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D33690113 |
tugsbayasgalan
force-pushed
the
export-D33690113
branch
from
b5174c2
to
8e715ac
Compare
|
This pull request was exported from Phabricator. Differential Revision: D33690113 |
tugsbayasgalan
force-pushed
the
export-D33690113
branch
from
8e715ac
to
7251bfe
Compare
|
This pull request was exported from Phabricator. Differential Revision: D33690113 |
tugsbayasgalan
force-pushed
the
export-D33690113
branch
from
7251bfe
to
94dee7c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D33690113 |
tugsbayasgalan
force-pushed
the
export-D33690113
branch
from
94dee7c
to
1e5e443
Compare
|
This pull request was exported from Phabricator. Differential Revision: D33690113 |
tugsbayasgalan
force-pushed
the
export-D33690113
branch
from
1e5e443
to
f134499
Compare
|
This pull request was exported from Phabricator. Differential Revision: D33690113 |
|
This pull request was exported from Phabricator. Differential Revision: D33690113 |
tugsbayasgalan
force-pushed
the
export-D33690113
branch
from
25a97a5
to
09dbe31
Compare
|
This pull request was exported from Phabricator. Differential Revision: D33690113 |
tugsbayasgalan
force-pushed
the
export-D33690113
branch
from
09dbe31
to
0c89ce4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D33690113 |
tugsbayasgalan
force-pushed
the
export-D33690113
branch
from
0c89ce4
to
eb2a792
Compare
|
This pull request was exported from Phabricator. Differential Revision: D33690113 |
tugsbayasgalan
force-pushed
the
export-D33690113
branch
from
eb2a792
to
1e76b2f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D33690113 |
tugsbayasgalan
force-pushed
the
export-D33690113
branch
from
1e76b2f
to
f239e64
Compare
|
This pull request was exported from Phabricator. Differential Revision: D33690113 |
tugsbayasgalan
force-pushed
the
export-D33690113
branch
from
f239e64
to
8f2fc25
Compare
Summary: Pull Request resolved: pytorch#71578 Use more robust way of extracting upgrader min and max versions Test Plan: omgitsgreen Reviewed By: cccclai Differential Revision: D33690113 fbshipit-source-id: 5c1f7b90bcd5b57f9984a99ff8f7a7aad1a3c7d8
|
This pull request was exported from Phabricator. Differential Revision: D33690113 |
tugsbayasgalan
force-pushed
the
export-D33690113
branch
from
8f2fc25
to
b3990b1
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 28, 2022
Summary: Pull Request resolved: #71578 Use more robust way of extracting upgrader min and max versions Test Plan: omgitsgreen Reviewed By: cccclai Differential Revision: D33690113 fbshipit-source-id: 79a964acb26d7ca1354e104710a285b8da3f46d1
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 3, 2022
Summary: Pull Request resolved: pytorch/pytorch#71578 Use more robust way of extracting upgrader min and max versions Test Plan: omgitsgreen Reviewed By: cccclai Differential Revision: D33690113 fbshipit-source-id: 79a964acb26d7ca1354e104710a285b8da3f46d1 (cherry picked from commit 9e316ee)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 3, 2022
Summary: Pull Request resolved: pytorch/pytorch#71578 Use more robust way of extracting upgrader min and max versions Test Plan: omgitsgreen Reviewed By: cccclai Differential Revision: D33690113 fbshipit-source-id: 79a964acb26d7ca1354e104710a285b8da3f46d1 (cherry picked from commit 9e316ee)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: pytorch/pytorch#71578 Use more robust way of extracting upgrader min and max versions Test Plan: omgitsgreen Reviewed By: cccclai Differential Revision: D33690113 fbshipit-source-id: 79a964acb26d7ca1354e104710a285b8da3f46d1 (cherry picked from commit 9e316ee)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: pytorch/pytorch#71578 Use more robust way of extracting upgrader min and max versions Test Plan: omgitsgreen Reviewed By: cccclai Differential Revision: D33690113 fbshipit-source-id: 79a964acb26d7ca1354e104710a285b8da3f46d1 (cherry picked from commit 9e316ee)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Use more robust way of extracting upgrader min and max versions
Test Plan: omgitsgreen
Differential Revision: D33690113