Add complex32 support to torch.lerp #75584

khushi-411 · 2022-04-10T16:42:58Z

Follows #74748 and #74537

cc @mruberry @ngimel @kshitij12345!

facebook-github-bot · 2022-04-10T16:43:04Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/75584
✖️ Python docs build was skipped
✖️ C++ docs build was skipped
❓Need help or want to give feedback on the CI? Visit our office hours

❌ 4 New Failures

As of commit 38bf73c (more details on the Dr. CI page):

Expand to see more

4/4 failures introduced in this PR

🕵️ 4 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages

pull / linux-bionic-cuda11.6-py3.10-gcc7 / test (default, 2, 4, linux.4xlarge.nvidia.gpu) (1/4)

Step: "Test" (full log | diagnosis details)

2022-09-06T05:09:54.7957201Z RuntimeError: test_decomp failed!

2022-09-06T05:09:53.0902929Z 
2022-09-06T05:09:53.0903101Z FAILED (errors=3, skipped=384, expected failures=25)
2022-09-06T05:09:53.0903120Z 
2022-09-06T05:09:53.0903246Z Generating XML reports...
2022-09-06T05:09:53.8035006Z Generated XML report: test-reports/python-unittest/test_decomp/TEST-TestDecompCUDA-20220906043431.xml
2022-09-06T05:09:54.7951039Z Traceback (most recent call last):
2022-09-06T05:09:54.7951802Z   File "/var/lib/jenkins/workspace/test/run_test.py", line 1104, in <module>
2022-09-06T05:09:54.7952960Z     main()
2022-09-06T05:09:54.7954013Z   File "/var/lib/jenkins/workspace/test/run_test.py", line 1082, in main
2022-09-06T05:09:54.7956564Z     raise RuntimeError(err_message)
2022-09-06T05:09:54.7957201Z RuntimeError: test_decomp failed!
2022-09-06T05:09:55.0915130Z 
2022-09-06T05:09:55.0915747Z real	35m30.134s
2022-09-06T05:09:55.0916117Z user	34m21.759s
2022-09-06T05:09:55.0916351Z sys	1m13.719s
2022-09-06T05:09:55.0974141Z ##[error]Process completed with exit code 1.
2022-09-06T05:09:55.1022826Z Prepare all required actions
2022-09-06T05:09:55.1023204Z Getting action download info
2022-09-06T05:09:55.2595323Z ##[group]Run ./.github/actions/get-workflow-job-id
2022-09-06T05:09:55.2596053Z with:
2022-09-06T05:09:55.2596613Z   github-token: ***

pull / linux-bionic-cuda11.6-py3.10-gcc7 / test (default, 4, 4, linux.4xlarge.nvidia.gpu) (2/4)

Step: "Test" (full log | diagnosis details)

2022-09-06T04:55:53.4081579Z RuntimeError: test_ops_jit failed!

2022-09-06T04:55:47.6301426Z 
2022-09-06T04:55:47.6301599Z FAILED (errors=1, skipped=105, expected failures=164)
2022-09-06T04:55:47.6301619Z 
2022-09-06T04:55:47.6301749Z Generating XML reports...
2022-09-06T04:55:47.7061715Z Generated XML report: test-reports/python-unittest/test_ops_jit/TEST-TestJitCUDA-20220906043612.xml
2022-09-06T04:55:53.4076275Z Traceback (most recent call last):
2022-09-06T04:55:53.4076761Z   File "/var/lib/jenkins/workspace/test/run_test.py", line 1104, in <module>
2022-09-06T04:55:53.4078379Z     main()
2022-09-06T04:55:53.4078731Z   File "/var/lib/jenkins/workspace/test/run_test.py", line 1082, in main
2022-09-06T04:55:53.4081274Z     raise RuntimeError(err_message)
2022-09-06T04:55:53.4081579Z RuntimeError: test_ops_jit failed!
2022-09-06T04:55:53.7368190Z 
2022-09-06T04:55:53.7368773Z real	19m47.972s
2022-09-06T04:55:53.7369590Z user	19m15.150s
2022-09-06T04:55:53.7369859Z sys	0m31.577s
2022-09-06T04:55:53.7429549Z ##[error]Process completed with exit code 1.
2022-09-06T04:55:53.7477697Z Prepare all required actions
2022-09-06T04:55:53.7478168Z Getting action download info
2022-09-06T04:55:53.9370854Z ##[group]Run ./.github/actions/get-workflow-job-id
2022-09-06T04:55:53.9371172Z with:
2022-09-06T04:55:53.9371636Z   github-token: ***

pull / linux-bionic-cuda11.6-py3.10-gcc7 / test (default, 3, 4, linux.4xlarge.nvidia.gpu) (3/4)

Step: "Test" (full log | diagnosis details)

2022-09-06T05:04:16.0089340Z RuntimeError: test_ops_gradients failed!

2022-09-06T05:04:14.2777886Z 
2022-09-06T05:04:14.2778040Z FAILED (errors=7, skipped=3951, expected failures=83)
2022-09-06T05:04:14.2778060Z 
2022-09-06T05:04:14.2778166Z Generating XML reports...
2022-09-06T05:04:15.1053287Z Generated XML report: test-reports/python-unittest/test_ops_gradients/TEST-TestGradientsCUDA-20220906043303.xml
2022-09-06T05:04:16.0084722Z Traceback (most recent call last):
2022-09-06T05:04:16.0085814Z   File "/var/lib/jenkins/workspace/test/run_test.py", line 1104, in <module>
2022-09-06T05:04:16.0086622Z     main()
2022-09-06T05:04:16.0086959Z   File "/var/lib/jenkins/workspace/test/run_test.py", line 1082, in main
2022-09-06T05:04:16.0088981Z     raise RuntimeError(err_message)
2022-09-06T05:04:16.0089340Z RuntimeError: test_ops_gradients failed!
2022-09-06T05:04:16.2796573Z 
2022-09-06T05:04:16.2797288Z real	31m19.273s
2022-09-06T05:04:16.2797579Z user	30m14.310s
2022-09-06T05:04:16.2797812Z sys	1m38.538s
2022-09-06T05:04:16.2847065Z ##[error]Process completed with exit code 1.
2022-09-06T05:04:16.2891285Z Prepare all required actions
2022-09-06T05:04:16.2891625Z Getting action download info
2022-09-06T05:04:16.5824085Z ##[group]Run ./.github/actions/get-workflow-job-id
2022-09-06T05:04:16.5824381Z with:
2022-09-06T05:04:16.5824837Z   github-token: ***

pull / linux-bionic-cuda11.6-py3.10-gcc7 / test (default, 1, 4, linux.4xlarge.nvidia.gpu) (4/4)

Step: "Test" (full log | diagnosis details)

2022-09-06T06:10:59.6784258Z RuntimeError: test_ops failed!

2022-09-06T06:10:54.9332125Z Generated XML report: test-reports/python-unittest/test_ops/TEST-TestCommonCUDA-20220906043805.xml
2022-09-06T06:10:55.1445306Z Generated XML report: test-reports/python-unittest/test_ops/TEST-TestCompositeComplianceCUDA-20220906043805.xml
2022-09-06T06:10:56.0554097Z Generated XML report: test-reports/python-unittest/test_ops/TEST-TestFakeTensorNonErroringCUDA-20220906043805.xml
2022-09-06T06:10:56.2383191Z Generated XML report: test-reports/python-unittest/test_ops/TEST-TestMathBitsCUDA-20220906043805.xml
2022-09-06T06:10:56.3397218Z Generated XML report: test-reports/python-unittest/test_ops/TEST-TestTagsCUDA-20220906043805.xml
2022-09-06T06:10:59.6779320Z Traceback (most recent call last):
2022-09-06T06:10:59.6779827Z   File "/var/lib/jenkins/workspace/test/run_test.py", line 1104, in <module>
2022-09-06T06:10:59.6780700Z     main()
2022-09-06T06:10:59.6781113Z   File "/var/lib/jenkins/workspace/test/run_test.py", line 1082, in main
2022-09-06T06:10:59.6783783Z     raise RuntimeError(err_message)
2022-09-06T06:10:59.6784258Z RuntimeError: test_ops failed!
2022-09-06T06:10:59.9866898Z 
2022-09-06T06:10:59.9867149Z real	93m1.745s
2022-09-06T06:10:59.9867469Z user	91m42.376s
2022-09-06T06:10:59.9867899Z sys	1m27.529s
2022-09-06T06:10:59.9932773Z ##[error]Process completed with exit code 1.
2022-09-06T06:10:59.9981184Z Prepare all required actions
2022-09-06T06:10:59.9981561Z Getting action download info
2022-09-06T06:11:00.2369884Z ##[group]Run ./.github/actions/get-workflow-job-id
2022-09-06T06:11:00.2370201Z with:
2022-09-06T06:11:00.2370729Z   github-token: ***

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

torch/testing/_internal/common_methods_invocations.py

aten/src/ATen/native/cuda/Lerp.cu

facebook-github-bot · 2022-10-04T01:08:19Z

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

linux-foundation-easycla · 2022-10-04T01:08:57Z

The committers listed above are authorized under a signed CLA.

✅ login: khushi-411 / name: Khushi Agrawal (987d657, c9f19ac, 1a1c1a4, 8c6a3cb, bee3d79, cb9dcf9, 950f8be, 2603e07, bf94d10, 02aa0f6, cce669e, fd3be62, 5ee0860, 024e14a, 2556e14, cddef18, b4e465f, d423163, c5baa9d, 2513cda, e010a23, 38bf73c, 974e467)

pytorch-bot · 2022-10-04T09:38:27Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/75584

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4672e37:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

khushi-411 · 2022-10-04T09:38:34Z

/easycla

anjali411

LGTM! @khushi-411 is there anything blocking this PR?

khushi-411 · 2022-11-28T15:06:31Z

Hi, @anjali411! Thanks for reviewing.

@khushi-411 is there anything blocking this PR?

Yes, the CI failures are relevant. I'll resolve this by today. Thanks!

khushi-411 · 2022-11-30T16:17:17Z

@pytorchmergebot merge

The CI goes green, Merging this PR. Yay! Thanks for reviewing @anjali411 and @kshitij12345! :)

khushi-411 · 2022-11-30T16:18:47Z

I think approval is needed for one workflow. Gentle ping, @anjali411.

pytorchmergebot · 2022-11-30T16:20:35Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Follows pytorch#74748 and pytorch#74537 Pull Request resolved: pytorch#75584 Approved by: https://github.com/anjali411

jiterate lerp

987d657

facebook-github-bot added the cla signed label Apr 10, 2022

khushi-411 marked this pull request as draft April 10, 2022 16:43

pytorchbot added the open source label Apr 10, 2022

khushi-411 added 14 commits April 10, 2022 22:24

remove spaces

c9f19ac

Merge branch 'pytorch:master' into jiterator/lerp

1a1c1a4

add complex lerp op

8c6a3cb

Merge branch 'pytorch:master' into jiterator/lerp

bee3d79

try to fix failures

cb9dcf9

try to fix failures

950f8be

Merge branch 'master' into jiterator/lerp

2603e07

use opmath_t in jiterator

bf94d10

typo

02aa0f6

Merge branch 'pytorch:master' into jiterator/lerp

cce669e

Merge branch 'pytorch:master' into jiterator/lerp

fd3be62

fix llvm_complex and use opmath_t only for float16 or bfloat16 inputs

5ee0860

Merge branch 'pytorch:master' into jiterator/lerp

024e14a

add chalf support and remove jiterator from scalar lerp

2556e14

khushi-411 changed the title ~~[jiterator] lerp~~ [jiterator, complex32] lerp : cuda May 22, 2022

khushi-411 marked this pull request as ready for review May 22, 2022 20:09

khushi-411 requested review from mruberry and ngimel as code owners May 22, 2022 20:09

khushi-411 commented May 22, 2022

View reviewed changes

torch/testing/_internal/common_methods_invocations.py Outdated Show resolved Hide resolved

kshitij12345 reviewed May 22, 2022

View reviewed changes

torch/testing/_internal/common_methods_invocations.py Outdated Show resolved Hide resolved

add chalf support in lerp scalar

cddef18

kshitij12345 reviewed May 23, 2022

View reviewed changes

aten/src/ATen/native/cuda/Lerp.cu Outdated Show resolved Hide resolved

jiterate lerp scalar

b4e465f

khushi-411 force-pushed the jiterator/lerp branch from 1e9c31a to b4e465f Compare May 23, 2022 14:16

kshitij12345 reviewed May 30, 2022

View reviewed changes

aten/src/ATen/native/cuda/Lerp.cu Outdated Show resolved Hide resolved

ejguan added triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module module: jiterator labels May 31, 2022

khushi-411 added 5 commits May 31, 2022 23:03

get c++ type out of weight

d423163

Merge branch 'pytorch:master' into jiterator/lerp

c5baa9d

Merge branch 'pytorch:master' into jiterator/lerp

2513cda

Merge branch 'pytorch:master' into jiterator/lerp

e010a23

Merge branch 'pytorch:master' into jiterator/lerp

38bf73c

Merge branch 'master' into jiterator/lerp

974e467

mruberry requested a review from anjali411 October 4, 2022 15:55

Merge branch 'pytorch:master' into jiterator/lerp

58a05b6

anjali411 approved these changes Nov 28, 2022

View reviewed changes

khushi-411 added 3 commits November 28, 2022 20:36

Merge branch 'pytorch:master' into jiterator/lerp

62b433c

fix lerp_scalar (make CI happy)

c142e47

Merge branch 'pytorch:master' into jiterator/lerp

4672e37

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 30, 2022

pytorchmergebot added the Merged label Nov 30, 2022

pytorchmergebot closed this in b5ad909 Nov 30, 2022

khushi-411 deleted the jiterator/lerp branch December 1, 2022 05:13

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022

[jiterator, complex32] lerp : cuda (pytorch#75584)

c86be2d

Follows pytorch#74748 and pytorch#74537 Pull Request resolved: pytorch#75584 Approved by: https://github.com/anjali411

lezcano changed the title ~~[jiterator, complex32] lerp : cuda~~ Add complex32 support to torch.lerp Feb 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add complex32 support to torch.lerp #75584

Add complex32 support to torch.lerp #75584

khushi-411 commented Apr 10, 2022 •

edited by pytorch-bot bot

facebook-github-bot commented Apr 10, 2022 •

edited

🕵️ 4 new failures recognized by patterns

pull / linux-bionic-cuda11.6-py3.10-gcc7 / test (default, 2, 4, linux.4xlarge.nvidia.gpu) (1/4)

pull / linux-bionic-cuda11.6-py3.10-gcc7 / test (default, 4, 4, linux.4xlarge.nvidia.gpu) (2/4)

pull / linux-bionic-cuda11.6-py3.10-gcc7 / test (default, 3, 4, linux.4xlarge.nvidia.gpu) (3/4)

pull / linux-bionic-cuda11.6-py3.10-gcc7 / test (default, 1, 4, linux.4xlarge.nvidia.gpu) (4/4)

facebook-github-bot commented Oct 4, 2022

linux-foundation-easycla bot commented Oct 4, 2022 •

edited

pytorch-bot bot commented Oct 4, 2022 •

edited

khushi-411 commented Oct 4, 2022

anjali411 left a comment

khushi-411 commented Nov 28, 2022 •

edited

khushi-411 commented Nov 30, 2022

khushi-411 commented Nov 30, 2022

pytorchmergebot commented Nov 30, 2022

Add complex32 support to torch.lerp #75584

Add complex32 support to torch.lerp #75584

Conversation

khushi-411 commented Apr 10, 2022 • edited by pytorch-bot bot

facebook-github-bot commented Apr 10, 2022 • edited

🔗 Helpful links

❌ 4 New Failures

🕵️ 4 new failures recognized by patterns

pull / linux-bionic-cuda11.6-py3.10-gcc7 / test (default, 2, 4, linux.4xlarge.nvidia.gpu) (1/4)

pull / linux-bionic-cuda11.6-py3.10-gcc7 / test (default, 4, 4, linux.4xlarge.nvidia.gpu) (2/4)

pull / linux-bionic-cuda11.6-py3.10-gcc7 / test (default, 3, 4, linux.4xlarge.nvidia.gpu) (3/4)

pull / linux-bionic-cuda11.6-py3.10-gcc7 / test (default, 1, 4, linux.4xlarge.nvidia.gpu) (4/4)

facebook-github-bot commented Oct 4, 2022

linux-foundation-easycla bot commented Oct 4, 2022 • edited

pytorch-bot bot commented Oct 4, 2022 • edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/75584

✅ No Failures

khushi-411 commented Oct 4, 2022

anjali411 left a comment

Choose a reason for hiding this comment

khushi-411 commented Nov 28, 2022 • edited

khushi-411 commented Nov 30, 2022

khushi-411 commented Nov 30, 2022

pytorchmergebot commented Nov 30, 2022

Merge started

khushi-411 commented Apr 10, 2022 •

edited by pytorch-bot bot

facebook-github-bot commented Apr 10, 2022 •

edited

linux-foundation-easycla bot commented Oct 4, 2022 •

edited

pytorch-bot bot commented Oct 4, 2022 •

edited

khushi-411 commented Nov 28, 2022 •

edited