-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ComplexHalf Coverage Tracker #74537
Labels
feature
A request for a proper, new feature.
module: complex
Related to complex number support in PyTorch
module: half
Related to float16 half-precision floats
triaged
This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Comments
kshitij12345
added
module: complex
Related to complex number support in PyTorch
module: half
Related to float16 half-precision floats
labels
Mar 22, 2022
Probably prime candidate for being JITerated by default. |
VitalyFedyunin
added
triaged
This issue has been looked at a team member, and triaged and prioritized into an appropriate module
feature
A request for a proper, new feature.
labels
Mar 25, 2022
pytorchmergebot
pushed a commit
that referenced
this issue
Mar 28, 2022
Reference: #74537 Pull Request resolved: #74667 Approved by: https://github.com/anjali411
facebook-github-bot
pushed a commit
that referenced
this issue
Mar 29, 2022
Summary: Reference: #74537 Pull Request resolved: #74667 Approved by: https://github.com/anjali411 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/56e534094715e411009650c0596766b7d0ffcdfa Reviewed By: malfet Differential Revision: D35188060 fbshipit-source-id: d341247700aed345c4f4dab4396ded5d25871a6b
pytorchmergebot
pushed a commit
that referenced
this issue
Apr 1, 2022
Reference : #74537 `cat_backwards` (on CUDA) requires support for `fill`, have added support for `fill`. (Also `fill` requires `item` support) Now `fill` backward requires `sum` (will add it in later PR). Pull Request resolved: #75010 Approved by: https://github.com/anjali411
facebook-github-bot
pushed a commit
that referenced
this issue
Apr 4, 2022
Summary: Reference : #74537 `cat_backwards` (on CUDA) requires support for `fill`, have added support for `fill`. (Also `fill` requires `item` support) Now `fill` backward requires `sum` (will add it in later PR). Pull Request resolved: #75010 Approved by: https://github.com/anjali411 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/65b65af2367c451a88672e9cffd40bd839d7ccb7 Reviewed By: atalman Differential Revision: D35317407 fbshipit-source-id: f735f5090539a4f598b413a3c40181a10bd0ad58
This was referenced Apr 6, 2022
pytorchmergebot
pushed a commit
that referenced
this issue
Apr 6, 2022
Reference #74537 Pull Request resolved: #75156 Approved by: https://github.com/anjali411
pytorchmergebot
pushed a commit
that referenced
this issue
Apr 6, 2022
Reference #74537 Pull Request resolved: #75311 Approved by: https://github.com/anjali411
facebook-github-bot
pushed a commit
that referenced
this issue
Apr 7, 2022
Summary: Reference #74537 Pull Request resolved: #75156 Approved by: https://github.com/anjali411 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/1b3313f2cd03e68b14d942a9a2301a2cd14bcbec Reviewed By: b0noI Differential Revision: D35437862 fbshipit-source-id: 3d6ee93894376e39724dc2fc1aa4ed90795bf9bd
facebook-github-bot
pushed a commit
that referenced
this issue
Apr 7, 2022
Summary: Reference #74537 Pull Request resolved: #75311 Approved by: https://github.com/anjali411 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/b780e8a640da5380a5b8fe1956af3578ffdd67fe Reviewed By: b0noI Differential Revision: D35437866 fbshipit-source-id: e7b98517f1899604b756802e5102c44c59b9e5cc
pytorchmergebot
pushed a commit
that referenced
this issue
Apr 8, 2022
Reference: #74537 Pull Request resolved: #75498 Approved by: https://github.com/anjali411
pytorchmergebot
pushed a commit
that referenced
this issue
Apr 11, 2022
Reference: #74537 Pull Request resolved: #75592 Approved by: https://github.com/anjali411
facebook-github-bot
pushed a commit
that referenced
this issue
Apr 11, 2022
Summary: Reference: #74537 Pull Request resolved: #75498 Approved by: https://github.com/anjali411 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/dfa1d953c6e38c59e97a12dee75fac0838509c09 Reviewed By: b0noI Differential Revision: D35510877 fbshipit-source-id: 1228454d68f2bcfdd6991124851b170199d6b4ad
facebook-github-bot
pushed a commit
that referenced
this issue
Apr 11, 2022
Summary: Reference: #74537 Pull Request resolved: #75592 Approved by: https://github.com/anjali411 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/1a85699c03f902af23a9d2ddaae525fe4e077dbe Reviewed By: b0noI Differential Revision: D35550117 fbshipit-source-id: c1de082d4e2daf1eb1fad0b10625f7920387c817
pytorchmergebot
pushed a commit
that referenced
this issue
Apr 19, 2022
Reference #74537 Support for jiterating with `c10::complex<Half>`. Note that computation will take place in `complex<float>` by allowing implicit casting in JITerated code (similar to Half and BFloat16 which upcast to float for computation). We add `complex32` support for `sigmoid` and `sigmoid_backward` in this PR. This is tested with `test_ops.py::test_dtypes and test_ops.py::test_complex_half_reference_testing` Pull Request resolved: #75656 Approved by: https://github.com/ngimel
facebook-github-bot
pushed a commit
that referenced
this issue
Apr 19, 2022
Summary: Reference #74537 Support for jiterating with `c10::complex<Half>`. Note that computation will take place in `complex<float>` by allowing implicit casting in JITerated code (similar to Half and BFloat16 which upcast to float for computation). We add `complex32` support for `sigmoid` and `sigmoid_backward` in this PR. This is tested with `test_ops.py::test_dtypes and test_ops.py::test_complex_half_reference_testing` Pull Request resolved: #75656 Approved by: https://github.com/ngimel Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/e23cbd633f03af6ef311361b885d5d8e4a9a0f17 Reviewed By: seemethere Differential Revision: D35751447 fbshipit-source-id: 9ab0d5a528d7599e8ebeb190f0493e29a90c7169
malfet
pushed a commit
that referenced
this issue
Apr 20, 2022
Reference #74537 Support for jiterating with `c10::complex<Half>`. Note that computation will take place in `complex<float>` by allowing implicit casting in JITerated code (similar to Half and BFloat16 which upcast to float for computation). We add `complex32` support for `sigmoid` and `sigmoid_backward` in this PR. This is tested with `test_ops.py::test_dtypes and test_ops.py::test_complex_half_reference_testing` Pull Request resolved: #75656 Approved by: https://github.com/ngimel (cherry picked from commit e23cbd6)
facebook-github-bot
pushed a commit
that referenced
this issue
May 25, 2022
Summary: Follows #74537 and #74748 cc kshitij12345 Pull Request resolved: #77606 Approved by: https://github.com/kshitij12345, https://github.com/ngimel Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/6f4d2007255a7606e80492b063fed2fe672a5bd8 Reviewed By: mehtanirav Differential Revision: D36633663 fbshipit-source-id: 875cf9cf0402bf3d611f2345d385c14ef2cf0018
swang392
pushed a commit
that referenced
this issue
May 25, 2022
Reland: #77239 Ref: #74537 Pull Request resolved: #77999 Approved by: https://github.com/anjali411
swang392
pushed a commit
that referenced
this issue
May 25, 2022
Follows #74537 and #74748 cc @kshitij12345 Pull Request resolved: #77802 Approved by: https://github.com/kshitij12345, https://github.com/ngimel
pytorchmergebot
pushed a commit
that referenced
this issue
Jun 1, 2022
Ref: #74537 Pull Request resolved: #77640 Approved by: https://github.com/anjali411, https://github.com/ngimel
pytorchmergebot
pushed a commit
that referenced
this issue
Jun 1, 2022
Follows: #74537 and #74748 cc @kshitij12345! Pull Request resolved: #78458 Approved by: https://github.com/kshitij12345, https://github.com/anjali411
pytorchmergebot
pushed a commit
that referenced
this issue
Jun 2, 2022
Reland: #77640 Ref: #74537 Pull Request resolved: #78665 Approved by: https://github.com/ngimel
facebook-github-bot
pushed a commit
that referenced
this issue
Jun 3, 2022
Summary: Reland: #77640 Ref: #74537 Pull Request resolved: #78665 Approved by: https://github.com/ngimel Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/849b08f14b2a741d0b90bb7bfce0ebb3d07d1981 Reviewed By: b0noI Differential Revision: D36882243 fbshipit-source-id: d9272da1541e99a8226560d8de6a3da32e889bc1
pytorchmergebot
pushed a commit
that referenced
this issue
Jun 6, 2022
Follows #74537 cc @kshitij12345! Pull Request resolved: #77490 Approved by: https://github.com/ngimel
facebook-github-bot
pushed a commit
that referenced
this issue
Jun 7, 2022
Summary: Follows #74537 cc kshitij12345! Pull Request resolved: #77490 Approved by: https://github.com/ngimel Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/e7b96ad0786739e8b3d559d417bb7d0c9645bec5 Reviewed By: osalpekar Differential Revision: D36959220 Pulled By: osalpekar fbshipit-source-id: 27deac39868b7ca79deddeb9779e50d114c5e804
pytorchmergebot
pushed a commit
that referenced
this issue
Jun 8, 2022
Ref: #78458 Follows: #74537 and #74748 cc @kshitij12345 @anjali411 :) Pull Request resolved: #78718 Approved by: https://github.com/anjali411, https://github.com/kshitij12345
davidchencsl
pushed a commit
that referenced
this issue
Jun 8, 2022
Ref: #78458 Follows: #74537 and #74748 cc @kshitij12345 @anjali411 :) Pull Request resolved: #78718 Approved by: https://github.com/anjali411, https://github.com/kshitij12345
facebook-github-bot
pushed a commit
that referenced
this issue
Jun 8, 2022
Summary: Ref: #78458 Follows: #74537 and #74748 cc kshitij12345 anjali411 :) Pull Request resolved: #78718 Approved by: https://github.com/anjali411, https://github.com/kshitij12345 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/5b32c34450d69d677d2e721059e381134303b3fa Reviewed By: osalpekar Differential Revision: D37010871 Pulled By: osalpekar fbshipit-source-id: 1f63f299bb25140d5538be6c602bdd67f6bf8ddd
pytorchmergebot
pushed a commit
that referenced
this issue
Jun 13, 2022
Follows #74537 cc @kshitij12345 Pull Request resolved: #78062 Approved by: https://github.com/kshitij12345, https://github.com/anjali411
facebook-github-bot
pushed a commit
that referenced
this issue
Jun 15, 2022
Summary: Follows #74537 cc kshitij12345 Pull Request resolved: #78062 Approved by: https://github.com/kshitij12345, https://github.com/anjali411 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/56805881938f6a986aaa2554df7591bd9d046eb2 Reviewed By: malfet Differential Revision: D37119137 fbshipit-source-id: 9b1f9577bc1241c9b5b5ad70eb287d725ba73dfc
pytorchmergebot
pushed a commit
that referenced
this issue
Jun 27, 2022
Ref: #74537 Pull Request resolved: #79970 Approved by: https://github.com/peterbell10, https://github.com/anjali411
facebook-github-bot
pushed a commit
that referenced
this issue
Jun 30, 2022
Summary: Ref: #74537 Pull Request resolved: #79970 Approved by: https://github.com/peterbell10, https://github.com/anjali411 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2587849dbbf51d2d53b8440a002b66734d177e8 Reviewed By: b0noI Differential Revision: D37496052 fbshipit-source-id: 499e867bf4244df7d6d892983ef1c9e8e9954982
pytorchmergebot
pushed a commit
that referenced
this issue
Jun 30, 2022
Follows: #74537 and #74748 cc @kshitij12345 @anjali411 :) Pull Request resolved: #80030 Approved by: https://github.com/kshitij12345, https://github.com/anjali411
facebook-github-bot
pushed a commit
that referenced
this issue
Jul 5, 2022
Summary: Follows: #74537 and #74748 cc kshitij12345 anjali411 :) Pull Request resolved: #80030 Approved by: https://github.com/kshitij12345, https://github.com/anjali411 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/7002621a4f3b7a8d1f0fb49a6ca257d4f9b5326f Reviewed By: b0noI Differential Revision: D37578914 fbshipit-source-id: 8a1967bd1e56bae573ac1666fcc582df1e193333
pytorchmergebot
pushed a commit
that referenced
this issue
Nov 30, 2022
Follows #74748 and #74537 Pull Request resolved: #75584 Approved by: https://github.com/anjali411
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this issue
Dec 10, 2022
Follows pytorch#74748 and pytorch#74537 Pull Request resolved: pytorch#75584 Approved by: https://github.com/anjali411
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
A request for a proper, new feature.
module: complex
Related to complex number support in PyTorch
module: half
Related to float16 half-precision floats
triaged
This issue has been looked at a team member, and triaged and prioritized into an appropriate module
🚀 The feature, motivation and pitch
There have been multiple requests and issues (see #71680) to have better operator support for
complex32
. Currently it is almost impossible to do anything with aTensor
ofcomplex32
dtype (even printing doesn't work).All operators which support complex dtypes should ideally support
complex32
. Computation will occur incomplex64
similar toHalf
wherein computation occurs infloat
.NOTE : Math op support will mostly be enabled only on CUDA
Following is the operator coverage:
Fundamental Ops (expected 1.12)
complex32
) (PR: [complex-half] support casting (by updating copy_) #73847)storage
does supportcomplex32
tensor #73502NOTE: List will be updated if supporting above list requires supporting another operator
High-Priority Ops (based on user demand)
High-Priority Ops (expected 1.12)
Tensor Creation Ops:
Remaining Operators which support complex type (generated from OpInfo)
Misc:
test_torch.py
cc: @anjali411
Alternatives
No response
Additional context
No response
cc @ezyang @anjali411 @dylanbespalko @mruberry @lezcano @nikitaved
The text was updated successfully, but these errors were encountered: