[MPS] Add logical ops #80216

qqaatw · 2022-06-24T09:18:01Z

This PR adds logical_not, logical_and, logical_or, logical_xor.

facebook-github-bot · 2022-06-24T09:18:07Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/80216
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours

✅ No Failures (0 Pending)

As of commit c75330c (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

aten/src/ATen/native/mps/operations/BinaryOps.mm

albanD

SGTM
Will let @kulinseth get a second look.

kulinseth

Overall it looks good, modulo that comment.

aten/src/ATen/native/mps/operations/BinaryOps.mm

kulinseth

Looks good.

qqaatw · 2022-06-28T22:15:48Z

@pytorchbot merge -g

pytorchmergebot · 2022-06-28T22:17:11Z

@pytorchbot successfully started a merge job. Check the current status here

pytorchmergebot · 2022-06-28T22:17:16Z

Merge failed due to Refusing to merge as mandatory check(s) pull failed for rule superuser
Raised by https://github.com/pytorch/pytorch/actions/runs/2579457701

qqaatw · 2022-06-28T22:19:29Z

@pytorchbot rebase

pytorchmergebot · 2022-06-28T22:21:03Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2022-06-28T22:21:06Z

Successfully rebased add_logical_not_mm onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via git checkout add_logical_not_mm && git pull --rebase)

qqaatw · 2022-06-29T02:43:08Z

@pytorchbot merge -g

pytorchmergebot · 2022-06-29T02:44:29Z

@pytorchbot successfully started a merge job. Check the current status here

pytorchmergebot · 2022-06-29T02:44:38Z

@qqaatw your PR has been successfully merged.

github-actions · 2022-06-29T02:45:09Z

Hey @qqaatw.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Summary: This PR adds `logical_not`, `logical_and`, `logical_or`, `logical_xor`. Pull Request resolved: #80216 Approved by: https://github.com/albanD, https://github.com/kulinseth Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/5943aaa0c45bddef9b577cd0483627144585af0d Reviewed By: b0noI Differential Revision: D37522962 fbshipit-source-id: afbb6686de6aabd9b197b85946c8a8b07e41064d

This PR adds `logical_not`, `logical_and`, `logical_or`, `logical_xor`. Pull Request resolved: pytorch#80216 Approved by: https://github.com/albanD, https://github.com/kulinseth

qqaatw · 2022-07-15T06:31:27Z

@pytorchbot label "release notes: mps" "topic: new feature"

This PR adds `logical_not`, `logical_and`, `logical_or`, `logical_xor`. Pull Request resolved: pytorch#80216 Approved by: https://github.com/albanD, https://github.com/kulinseth

* MPS: Fixes (#78930) Cast integer to float in UnaryOps Add tensor dtype in key generation Enable FP16 scalars and use placeholder for alpha tensor in add/sum ops Fixes #ISSUE_NUMBER Pull Request resolved: #78930 Approved by: https://github.com/albanD * MPS: Binary cast fix by proper type promotion and remove spurious copy warning (#79185) Fixes #78019, #78020 Fixes #79185 Pull Request resolved: #79185 Approved by: https://github.com/albanD, https://github.com/razarmehr * MPS: add exponential op (#79188) Add exponential distribution Fixes #ISSUE_NUMBER Pull Request resolved: #79188 Approved by: https://github.com/razarmehr, https://github.com/albanD * [MPS] Delete unused vars from OperationUtils.mm Pull Request resolved: #79514 Approved by: https://github.com/kulinseth, https://github.com/albanD * [MPS] Fix getDefaultGenerator and copy_kernel_mps Returning reference to stack memory is really bad Pull Request resolved: #79515 Approved by: https://github.com/albanD * [MPS][BE]Do not use `new/delete[]` in `chainViewOperation` `std::array` will do just fine Pull Request resolved: #79516 Approved by: https://github.com/albanD * [MPS] Support stride of stride Fixes #79181 Pull Request resolved: #79521 Approved by: https://github.com/kulinseth * MPS: TopK raise an error if K>16 (#79677) * Error out in TopK when k>16. * Add a test case too. Fixes #78915 Pull Request resolved: #79677 Approved by: https://github.com/albanD * [MPS]: Add fix for squeezed input axes handling in BCE loss (#79676) Fixes #79527 Pull Request resolved: #79676 Approved by: https://github.com/razarmehr, https://github.com/albanD * MPS: Add amax and amin Ops with tests (#79682) * Add amax and amin with tests Fixes #ISSUE_NUMBER Pull Request resolved: #79682 Approved by: https://github.com/albanD * [MPS] Fix torch.uint8 support (#80049) `ScalarType.Byte` should be cast to `MPSDataTypeUInt8` And support for `torch.int8` as well as test those conversions in `TestMPS.test_to` Fixes #80006 Pull Request resolved: #80049 Approved by: https://github.com/albanD * [MPS] Fix binary ops between int32 tensor with int64 scalar (#80220) For some reason, tensor *op* scalar does not follow the normal binary promotion rules So cast output tensor to expected type if needed It seems that one should have casted input tensors to expected output tensor type, but it does not really work for boolean binary ops, so... Add output tensor type/shape to cached graph key Extend `TestMPS. test_add_scalars` to test for this regression Fixes #79835 Pull Request resolved: #80220 Approved by: https://github.com/albanD * [MPS] Add equal operator (#80195) Which is, in essence is composite of `eq`->`all`->`item` `native/mps/operators/Equal.cpp` is an almost verbatim copy of `native/cuda/Equal.cpp` Fix codegen by generating MPSFunctions headers Pull Request resolved: #80195 Approved by: https://github.com/albanD * [MPS] add `aten::normal.Tensor_float` `aten::normal.float_Tensor` `aten::normal.Tensor_Tensor` (#80297) Fixes #ISSUE_NUMBER Pull Request resolved: #80297 Approved by: https://github.com/albanD, https://github.com/kulinseth * [MPS] Add flip (#80214) Fixes #ISSUE_NUMBER Pull Request resolved: #80214 Approved by: https://github.com/DenisVieriu97, https://github.com/albanD * [MPS] Add logical ops (#80216) This PR adds `logical_not`, `logical_and`, `logical_or`, `logical_xor`. Pull Request resolved: #80216 Approved by: https://github.com/albanD, https://github.com/kulinseth * [MPS] Add glu (#79866) Adds mps op for `aten::glu.out`. Pull Request resolved: #79866 Approved by: https://github.com/kulinseth, https://github.com/albanD * [MPS] Fix std/var cache issue (#80502) Use `getTensorsStringKey` which has tensor shape info added as part of the key to prevent cache lookup issue when the shape of input tensor is changed. Fixes #80499 Pull Request resolved: #80502 Approved by: https://github.com/malfet, https://github.com/kulinseth * Add scatter support for view operations (#79939) * Add scatter support for view operations; #78074, #78886, #79672 * Update test_slicing_replace_column to properly test different sizes * Handle in-place changes for binary ops; add new testcase * Add new view ops testing scatter; add MPSDebugConfig.h config file for debugging purposes * Merge gatherViewTensor and scatterViewTensor into a generic function * Add scatter on demand in scatterViewOperation instead of caching it into a generic graph * Create separate graphs for scatter and gather; * Create scatter graph at scatter time Fixes #ISSUE_NUMBER Pull Request resolved: #79939 Approved by: https://github.com/razarmehr * MPS: Fix handling of 1D tensors in linear backward (#80759) Fixes ##79784 Pull Request resolved: #80759 Approved by: https://github.com/ezyang * [MPS] Move the View ops to a separate file and reduce the number of graphs created (#80491) This is dependent on the PR to go in first: #79939 Remove the data_ptr from the View Graph key which reduces the number of graphs created significantly. Don't wait when copying from MPS to MPS tensors Pull Request resolved: #80491 Approved by: https://github.com/malfet * [MPS] Add softplus backward (#79873) Fixes #ISSUE_NUMBER Pull Request resolved: #79873 Approved by: https://github.com/malfet * [MPS] Add argmin (#80828) This PR 1. adds argmin 2. refactors `reduction_type` in `ReduceOps.mm` with enum. Co-authored by Kulin Seth <kulinseth@gmail.com> Pull Request resolved: #80828 Approved by: https://github.com/malfet * [MPS] Fix LSTM batch_first output transposed (#80597) The output of LSTM with `batch_first` should be transposed back to batch first format. Fixes #80306 Pull Request resolved: #80597 Approved by: https://github.com/kulinseth * [MPS][BE] Introduce MPSUnaryCachedGraph (#81033) I.e. CachedGraph that has input and output tensors Also, add `MPSGraphCache::LookUpAs` template, which combines LookUp with static_cast to target type Pull Request resolved: #81033 Approved by: https://github.com/kulinseth * [MPS] Add test consistency from OpInfo based tests from PR 78504 (#79532) Pull Request resolved: #79532 Approved by: https://github.com/albanD, https://github.com/malfet * [MPS] Add huber loss (#80163) Fixes #ISSUE_NUMBER Pull Request resolved: #80163 Approved by: https://github.com/kulinseth, https://github.com/malfet * Remove two tests dependent on the MPS serialization checkin. * Fix lint error (FLAKE8) F401 * Remove the serialization test from test_mps as its support is not there in 1.12.1. Co-authored-by: Kulin Seth <kulinseth@gmail.com> Co-authored-by: Nikita Shulga <nikita.shulga@gmail.com> Co-authored-by: Kulin Seth <kulin_seth@apple.com> Co-authored-by: Abhishek Pathak <abhipathak97@gmail.com> Co-authored-by: Nikita Shulga <nshulga@fb.com> Co-authored-by: qqaatw <qqaatw@gmail.com> Co-authored-by: Ramin Azarmehr <razarmehr@apple.com>

qqaatw requested review from kulinseth and bdhirsh as code owners June 24, 2022 09:18

facebook-github-bot added the cla signed label Jun 24, 2022

qqaatw mentioned this pull request Jun 24, 2022

General MPS op coverage tracking issue #77764

Open

pytorchbot added the open source label Jun 24, 2022

qqaatw changed the title ~~[MPS] Add logical not op~~ [MPS] [WIP] Add logical ops Jun 24, 2022

qqaatw changed the title ~~[MPS] [WIP] Add logical ops~~ [MPS] Add logical ops Jun 24, 2022

qqaatw commented Jun 26, 2022

View reviewed changes

aten/src/ATen/native/mps/operations/BinaryOps.mm Outdated Show resolved Hide resolved

mruberry requested a review from albanD June 27, 2022 13:26

mruberry added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 27, 2022

albanD approved these changes Jun 28, 2022

View reviewed changes

albanD added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 28, 2022

kulinseth reviewed Jun 28, 2022

View reviewed changes

aten/src/ATen/native/mps/operations/BinaryOps.mm Outdated Show resolved Hide resolved

kulinseth approved these changes Jun 28, 2022

View reviewed changes

qqaatw added 5 commits June 28, 2022 22:21

Add logical not

887f52f

Add and, or, xor

a73834e

Add tests

a309882

Update aten/src/ATen/native/mps/operations/BinaryOps.mm

b33cc4d

conditional resizing

c75330c

pytorchmergebot force-pushed the add_logical_not_mm branch from 7803cc3 to c75330c Compare June 28, 2022 22:21

pytorchmergebot added the Merged label Jun 29, 2022

pytorchmergebot closed this in 5943aaa Jun 29, 2022

pytorch-bot bot added release notes: mps Release notes category topic: new features topic category labels Jul 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MPS] Add logical ops #80216

[MPS] Add logical ops #80216

qqaatw commented Jun 24, 2022 •

edited

Loading

facebook-github-bot commented Jun 24, 2022 •

edited

Loading

albanD left a comment

kulinseth left a comment

kulinseth left a comment

qqaatw commented Jun 28, 2022

pytorchmergebot commented Jun 28, 2022

pytorchmergebot commented Jun 28, 2022

qqaatw commented Jun 28, 2022

pytorchmergebot commented Jun 28, 2022

pytorchmergebot commented Jun 28, 2022

qqaatw commented Jun 29, 2022

pytorchmergebot commented Jun 29, 2022

pytorchmergebot commented Jun 29, 2022

github-actions bot commented Jun 29, 2022

qqaatw commented Jul 15, 2022

[MPS] Add logical ops #80216

[MPS] Add logical ops #80216

Conversation

qqaatw commented Jun 24, 2022 • edited Loading

facebook-github-bot commented Jun 24, 2022 • edited Loading

🔗 Helpful links

✅ No Failures (0 Pending)

albanD left a comment

Choose a reason for hiding this comment

kulinseth left a comment

Choose a reason for hiding this comment

kulinseth left a comment

Choose a reason for hiding this comment

qqaatw commented Jun 28, 2022

pytorchmergebot commented Jun 28, 2022

pytorchmergebot commented Jun 28, 2022

qqaatw commented Jun 28, 2022

pytorchmergebot commented Jun 28, 2022

pytorchmergebot commented Jun 28, 2022

qqaatw commented Jun 29, 2022

pytorchmergebot commented Jun 29, 2022

pytorchmergebot commented Jun 29, 2022

github-actions bot commented Jun 29, 2022

qqaatw commented Jul 15, 2022

qqaatw commented Jun 24, 2022 •

edited

Loading

facebook-github-bot commented Jun 24, 2022 •

edited

Loading