MPS: Fix handling of 1D tensors in linear backward

[kulinseth]

Fixes ##79784

[facebook-github-bot]

🔗 Helpful links

• 🧪  See artifacts and rendered test results at hud.pytorch.org/pr/80759
• 📄  Preview Python docs built from this PR
• 📄  Preview C++ docs built from this PR
• ❓Need help or want to give feedback on the CI? Visit our office hours

❌ 2 New Failures

As of commit 4953dc1 (more details on the Dr. CI page):

Expand to see more

---

• 2/2 failures introduced in this PR

---

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages

trunk / linux-bionic-rocm5.1-py3.7 / test (default, 2, 2, linux.rocm.gpu) (1/2)

Step: "Save test results" (full log | diagnosis details | 🔁 rerun)

2022-07-01T23:53:34.6532294Z ##[error]Process completed with exit code 1.

2022-07-01T23:53:34.5953382Z ##[error]The operation was canceled.
2022-07-01T23:53:34.6092711Z ##[group]Run # copy test results back to the mounted workspace, needed sudo, resulting permissions were correct
2022-07-01T23:53:34.6093395Z �[36;1m# copy test results back to the mounted workspace, needed sudo, resulting permissions were correct�[0m
2022-07-01T23:53:34.6093994Z �[36;1mdocker exec -t "" sh -c "cd ../pytorch && sudo cp -R test/test-reports ../workspace/test"�[0m
2022-07-01T23:53:34.6117036Z shell: /bin/bash -e {0}
2022-07-01T23:53:34.6117456Z env:
2022-07-01T23:53:34.6117724Z   GIT_DEFAULT_BRANCH: master
2022-07-01T23:53:34.6118097Z   DOCKER_HOST: unix:///run/user/1123/docker.sock
2022-07-01T23:53:34.6118442Z ##[endgroup]
2022-07-01T23:53:34.6494370Z Error: No such container: 
2022-07-01T23:53:34.6532294Z ##[error]Process completed with exit code 1.
2022-07-01T23:53:34.6599796Z Prepare all required actions
2022-07-01T23:53:34.6600693Z Getting action download info
2022-07-01T23:53:34.9369588Z Download action repository 'nick-fields/retry@71062288b76e2b6214ebde0e673ce0de1755740a' (SHA:71062288b76e2b6214ebde0e673ce0de1755740a)
2022-07-01T23:53:35.4110487Z ##[group]Run ./.github/actions/get-workflow-job-id
2022-07-01T23:53:35.4110785Z with:
2022-07-01T23:53:35.4111404Z   github-token: ***
2022-07-01T23:53:35.4111638Z env:
2022-07-01T23:53:35.4111858Z   GIT_DEFAULT_BRANCH: master
2022-07-01T23:53:35.4112155Z   DOCKER_HOST: unix:///run/user/1123/docker.sock
2022-07-01T23:53:35.4112425Z ##[endgroup]

pull / linux-xenial-py3-clang5-mobile-custom-build-static / build (2/2)

Step: "Setup Linux" (full log | diagnosis details | 🔁 rerun)

2022-07-01T18:07:08.6813838Z ##[error]Process completed with exit code 1.

2022-07-01T18:06:52.8871318Z �[36;1mretry () { "$@"  || (sleep 1 && "$@") || (sleep 2 && "$@") }�[0m
2022-07-01T18:06:52.8871738Z �[36;1mretry aws ecr get-login*** "$AWS_DEFAULT_REGION" | docker login --username AWS \�[0m
2022-07-01T18:06:52.8872070Z �[36;1m    --password-stdin "$AWS_ACCOUNT_ID.dkr.ecr.$AWS_DEFAULT_REGION.amazonaws.com"�[0m
2022-07-01T18:06:52.8882504Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
2022-07-01T18:06:52.8882735Z env:
2022-07-01T18:06:52.8882908Z   AWS_RETRY_MODE: standard
2022-07-01T18:06:52.8883084Z   AWS_MAX_ATTEMPTS: 5
2022-07-01T18:06:52.8883288Z   AWS_DEFAULT_REGION: us-east-1
2022-07-01T18:06:52.8883477Z ##[endgroup]
2022-07-01T18:07:08.6787997Z Error response from daemon: Get "https://308535385114.dkr.ecr.us-east-1.amazonaws.com/v2/": net/http: request canceled (Client.Timeout exceeded while awaiting headers)
2022-07-01T18:07:08.6813838Z ##[error]Process completed with exit code 1.
2022-07-01T18:07:08.6859514Z Prepare all required actions
2022-07-01T18:07:08.6859752Z Getting action download info
2022-07-01T18:07:08.8240726Z Download action repository 'nick-fields/retry@71062288b76e2b6214ebde0e673ce0de1755740a' (SHA:71062288b76e2b6214ebde0e673ce0de1755740a)
2022-07-01T18:07:08.9279251Z ##[group]Run ./.github/actions/get-workflow-job-id
2022-07-01T18:07:08.9279468Z with:
2022-07-01T18:07:08.9279813Z   github-token: ***
2022-07-01T18:07:08.9279998Z ##[endgroup]
2022-07-01T18:07:08.9304692Z ##[group]Run nick-fields/retry@71062288b76e2b6214ebde0e673ce0de1755740a
2022-07-01T18:07:08.9304919Z with:
2022-07-01T18:07:08.9305065Z   shell: bash

---

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

[kulinseth]

@pytorchbot rebase

[pytorchmergebot]

@pytorchbot successfully started a rebase job. Check the current status here

[pytorchmergebot]

Successfully rebased linear_1D onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via git checkout linear_1D && git pull --rebase)

[ezyang]

This test case would have been automatically applied for you if MPS was using OpInfo testing:

def sample_inputs_linear(self, device, dtype, requires_grad, **kwargs):
    features_options = [[3, 4], [8, 8]]
    batch_options: List[List[int]] = [
        [],  # no batch
        [0],
        [8],
        [2, 3],
    ]

Please consider making the MPS tests use OpInfos!

[ezyang]

cc @mruberry

[albanD]

Scaffolding for this just landed: #79532
There is still some work to reduce flakyness in MPS ops though.

[ezyang]

@pytorchbot merge

[pytorchmergebot]

@pytorchbot successfully started a merge job. Check the current status here

[pytorchmergebot]

Merge failed due to Refusing to merge as mandatory check(s) pull failed for rule superuser
Raised by https://github.com/pytorch/pytorch/actions/runs/2607232182

[ezyang]

@pytorchbot merge -f

[pytorchmergebot]

@pytorchbot successfully started a merge job. Check the current status here

[github-actions]

Hey @kulinseth.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.