Enable xdoctest runner in CI for real this time #83816
Conversation
Erotemic
requested review from
lezcano,
a team,
jeffdaily,
BowenBao,
shubhambhokare1,
mrshenli,
zhaojuanmao,
pritamdamania87,
rohan-varma,
mingzhe09088,
H-Huang,
awgu,
albanD,
jbschlosser,
saketh-are and
soulitzer
as code owners
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 7b38a9a (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: distributed
Erotemic
force-pushed
the
dev/enable-xdoctest-for-real
branch
2 times, most recently
from
f0b140b
to
ef7aa07
Compare
Erotemic
requested review from
robieta,
fmassa,
soumith and
ezyang
as code owners
|
Latest commits disable more of the doctests in hopes that some subset of them are causing the errors, if so I'll start to hone in on exactly which ones are problematic. While doing this I started linting the doctests to help ensure they also conform with pep8 standards. |
ngimel
added
the
triaged
Erotemic
force-pushed
the
dev/enable-xdoctest-for-real
branch
from
eab13ab
to
db3f034
Compare
Erotemic
force-pushed
the
dev/enable-xdoctest-for-real
branch
from
e693a1a
to
81e9bab
Compare
|
nuuuu you pushed lol. I was pretty sure the previous ci was going to be ok. I've confirmed the lief errors are not your fault and was going to bypassed them |
|
It had already failed by the time I force pushed. Your POSIX branch (57dcd93) is merged in what I recently pushed. Either way, if you want to try something, I won't touch it. |
|
well, now we wait. The failures I'm expecting to see are the py-lief binary ones, as well as a mypy failure on sm86 |
|
@pytorchbot merge -f "all failures are preexisting failures" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Builds on #83317 and enables running the doctests. Just need to figure out what is causing the failures.
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu