Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Renable assert diagnostic test #85999

Closed
wants to merge 3 commits into from
Closed

[ONNX] Renable assert diagnostic test #85999

wants to merge 3 commits into from

Conversation

BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented Sep 30, 2022 •
edited by pytorchmergebot

Stack from ghstack (oldest at bottom):

Fix to properly clear 'background_context' of export diagnostic 'engine' in clear.

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 30, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85999

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5bf945d:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Sep 30, 2022
BowenBao added a commit that referenced this pull request Sep 30, 2022
@BowenBao
[ONNX] Renable assert diagnostic test
585452b 
ghstack-source-id: 39ca5c72c0a3d0a697bccd26895e522f6f0f6685
Pull Request resolved: #85999
@BowenBao BowenBao added topic: bug fixes topic category module: onnx Related to torch.onnx labels Sep 30, 2022
@BowenBao
Copy link
Collaborator Author

BowenBao commented Oct 1, 2022

@abock please take a look.

@BowenBao BowenBao added this to the 1.13.0 milestone Oct 3, 2022
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 3, 2022
@BowenBao
Copy link
Collaborator Author

BowenBao commented Oct 3, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@BowenBao
Update on "[ONNX] Renable assert diagnostic test"
39b6634 
Fix to properly clear 'background_context' of export diagnostic 'engine' in `clear`.


[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/BowenBao/158/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/85999)

pytorchmergebot pushed a commit that referenced this pull request Oct 3, 2022
@BowenBao
[ONNX] Renable assert diagnostic test
f0b48f0 
ghstack-source-id: 9d79e9583fe3132bcb1b99fe19c87291df1ec918
Pull Request resolved: #85999
@facebook-github-bot
Copy link
Contributor

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 4, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@BowenBao
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@BowenBao
Update on "[ONNX] Renable assert diagnostic test"
5bf945d 
Fix to properly clear 'background_context' of export diagnostic 'engine' in `clear`.


[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/BowenBao/158/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/85999)

pytorchmergebot pushed a commit that referenced this pull request Oct 11, 2022
@BowenBao
[ONNX] Renable assert diagnostic test
4145ded 
ghstack-source-id: f9114294eeffdcea7c5a241646c306154fb822a4
Pull Request resolved: #85999
@BowenBao
Copy link
Collaborator Author

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

BowenBao added a commit that referenced this pull request Oct 13, 2022
@BowenBao
[ONNX] Renable assert diagnostic test (#85999)
3540071 
Fix to properly clear 'background_context' of export diagnostic 'engine' in `clear`.

Pull Request resolved: #85999
Approved by: https://github.com/abock
This was referenced Oct 13, 2022
Merged
Closed
malfet pushed a commit that referenced this pull request Oct 18, 2022
@BowenBao
[ONNX] Renable assert diagnostic test (#85999) (#86924)
1ebff1d 
Fix to properly clear 'background_context' of export diagnostic 'engine' in `clear`.

Pull Request resolved: #85999
Approved by: https://github.com/abock
@malfet malfet mentioned this pull request Nov 23, 2022
Closed
@facebook-github-bot facebook-github-bot deleted the gh/BowenBao/158/head branch June 8, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abock abock abock approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: bug fixes topic category
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@BowenBao @pytorchmergebot @facebook-github-bot @abock @pytorchbot