[v.1.13.0] Release Tracker

[atalman]

We cut a release branch for the 1.13.0 release.

Our plan from this point from this point is roughly:

• Phase 1 (until 10/21): work on finalizing the release branch
• Phase 2 (after 10/21): perform extended integration/stability/performance testing based on Release Candidate builds.

This issue is for tracking cherry-picks to the release branch.

Cherry-Pick Criteria

Phase 1 (until 10/21/22):

Only low-risk changes may be cherry-picked from master:

1. Fixes to regressions against the most recent minor release (e.g. 1.12 for 1.13 release; see module: regression issue list)
2. Critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks
3. Fixes to new features introduced in the most recent minor release (e.g. 1.12.0 for 1.13 release)
4. Test/CI fixes
5. Documentation improvements
6. Compilation fixes or ifdefs required for different versions of the compilers or third-party libraries
7. Release branch specific changes (e.g. change version identifiers)

Any other change requires special dispensation from the release managers (currently @atalman, @weiwangmeta, @izaitsevfb, @malfet ). If this applies to your change please write "Special Dispensation" in the "Criteria Category:" template below and explain.

Phase 2 (after 10/21/22):

Note that changes here require us to rebuild a Release Candidate and restart extended testing (likely delaying the release). Therefore, the only accepted changes are Release-blocking critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks

Changes will likely require a discussion with the larger release team over VC or Slack.

Cherry-Pick Process

1. Ensure your PR has landed in master. This does not apply for release-branch specific changes (see Phase 1 criteria).

2. Create (but do not land) a PR against the release branch.

   # Find the hash of the commit you want to cherry pick
   # (for example, abcdef12345)
   git log
   
   git fetch origin release/1.13
   git checkout release/1.13
   git cherry-pick abcdef12345
   
   # Submit a PR based against 'release/1.13' either:
   # via the GitHub UI
   git push my-fork
   
   # via the GitHub CLI
   gh pr create --base release/1.13

3. Make a request below with the following format:

Link to landed master PR (if applicable):
* 

Link to release branch PR:
* 

Criteria Category:
* 

1. Someone from the release team will reply with approved / denied or ask for more information.
2. If approved, someone from the release team will merge your PR once the tests pass. Do not land the release branch PR yourself.

NOTE: Our normal tools (ghstack / ghimport, etc.) do not work on the release branch.

Please note HUD Link with branch CI status and link to the HUD to be provided here.
HUD

Versions

1.13.0

[zou3519]

Link to landed master PR (if applicable):

• n/a

Link to release branch PR:

• [1.13] Remove torch.vmap #86333

Criteria Category:

• Release branch specific changes (remove prototype feature)

---

@malfet: merged

[atalman]

Link to landed master PR (if applicable):

• Conditionally build the TestApp benchmark based on lite interpreter #86314

Link to release branch PR:

• Conditionally build the TestApp benchmark based on lite interpreter (… #86377

Criteria Category:

• Fix full jit builds during our CircleCI nightly. Fix is required for ios cocoapod release

---

@atalman merged

[syed-ahmed]

Link to landed master PR (if applicable):

• Sets CUDA_MODULE_LOADING to LAZY when not set by the user #85692

Link to release branch PR:

• [1.13] Sets CUDA_MODULE_LOADING to LAZY when not set by the user #86509

Criteria Category:

• N/A (sets environment variable CUDA_MODULE_LOADING='LAZY' to save memory)

---

@malfet: merged

[atalman]

Link to landed master PR (if applicable):

• NA

Link to release branch PR:

• Release 1.13, Install torch from test channel, Pin build… #86290

Criteria Category:

• CI: Release only change

--
@atalman Merged

[atalman]

Link to landed master PR (if applicable):

• Fix for binary upload step, use bash shell rather then default sh #86382

Link to release branch PR:

• Fix for the binary upload #86385

Criteria Category:

• CI Critical fix

--
@atalman merged

[atalman]

Link to landed master PR (if applicable):

• NA

Link to release branch PR:

• Fix binary builds for the release - unblock release #86484

Criteria Category:

• CI : Release only change, fix RC names

---

@atalman megred

[EikanWang]

Link to landed master PR (if applicable):

• Fix the performance issue that the for-loop before ExternallCall could not be parallelized. #85056

Link to release branch PR:

• Fix the performance issue that the for-loop before ExternallCall #86516

Criteria Category:

• Fix performance regression from previous release.

---

@malfet: merged as it's part of 3 PRs set that should have been landed in group.

[soulitzer]

Link to landed master PR (if applicable):

• N/A (originally landed as part of Add multi-grad hooks #86260, the bug fix has been factored into its own PR here)

Link to release branch PR:

• Bug fix for torch._C._will_engine_execute_node #86672

Criteria Category:

• bug fix

---

@malfet: merged

[zou3519]

Link to landed master PR (if applicable):

• Add version selector back to functorch docs #86602

Link to release branch PR:

• Add version selector back to functorch docs (#86602) #86689

Criteria Category:

• Documentation improvements

---

@atalman merged

[zou3519]

Link to landed master PR (if applicable):

• N/A

Link to release branch PR:

• [1.13] Release-only improvements to functorch docs #86693

Criteria Category:

• Release branch specific changes (change functorch documentation version specifier and links to colab notebooks)

---

@malfet: merged

[jeffdaily]

Link to landed master PR (if applicable):

• [ROCm] set nvfuser default to disabled, keep CI #86369

Link to release branch PR:

• [ROCm] set nvfuser default to disabled, keep CI (#86369) #86725

Criteria Category:

• bug fix

---

@atalman merged

[jerryzh168]

Link to landed master PR (if applicable):

• [quant] Move the order of x86 engine to avoid changing the default qengine #86631

Link to release branch PR:

• [quant] Move the order of x86 engine to avoid changing the default qe… #86726

Criteria Category:

• critical fix for crashes
  See summary of [quant] Move the order of x86 engine to avoid changing the default qengine #86631 for context

---

@malfet: merged

[CaoE]

Link to landed master PR (if applicable):

• Make the data types of output and input consistenst for batchnorm #84410

Link to release branch PR:

• Make the data types of output and input consistenst for batchnorm #86784

Criteria Category:

• bug fix for:batchnorm

---

@atalman merged

[malfet]

Linkt to landed master PR:

• [MPS] Better error message for slow_conv2d_forward #86303

Link to release branch PR:

• [MPS] Better error message for slow_conv2d_forward #86844

Criteria Category:

• Documentation improvements / Fixes to regressions against the most recent minor release

---

@malfet: merged

[malfet]

Link to landed master PR:

• [DOC] Use type hints to show annotation in the docs #79086

Link to release branch PR:

• [DOC] Use type hints to show annotation in the docs #86851

Criteria Category:

• Documentation improvements

---

@malfet: merged

[atalman]

Link to landed master PR (if applicable):

• ci: Just use regular checkout #86824

Link to release branch PR:

• ci: Just use regular checkout (#86824) #86895

Criteria Category:

• Critical CI Fix

---

@atalman merged

[XiaobingSuper]

Link to landed master PR (if applicable):

• n/a

Link to release branch PR:

• update quantization doc: add x86 backend as default backend of server inference #86900

Criteria Category:

• Documentation improvements for quantization

---

@malfet: This behavior was reverted in #86726, so should it really be documented as default backend?

[zou3519]

Link to landed master PR (if applicable):

• Add vmap support for slogdet; fix regression from functorch 0.2.1 #86815

Link to release branch PR:

• Add vmap support for slogdet; fix regression from functorch 0.2.1 (#8… #86902

Criteria Category:

• Fixes to regressions against the most recent minor release

---

@malfet: merged

[zou3519]

Link to landed master PR (if applicable):

• [functorch] Add more details to the functorch install page #86823

Link to release branch PR:

• [functorch] Add more details to the functorch install page (#86823) #86903

Criteria Category:

• Documentation improvements

---

@atalman merged

[atalman]

Link to landed master PR (if applicable):

• NA

Link to release branch PR:

• [CI] Fix builder ref for release, linux only #86904

Criteria Category:

• [CI] Critical fix

---

@atalman merged

[BowenBao]

Link to landed master PR (if applicable):

• [ONNX] Support device().type() string comparison with constant #86168

Link to release branch PR:

• [ONNX] Support device().type() string comparison with constant (#86168) #86921

Criteria Category:

• bug fix

---

@malfet: merged

[BowenBao]

Link to landed master PR (if applicable):

• [ONNX] Fix scalar_type_analysis metadata for copied constant #86716

Link to release branch PR:

• [ONNX] Fix scalar_type_analysis metadata for copied constant (#86716) #86923

Criteria Category:

• fix regression

---

@malfet: merged

[BowenBao]

Link to landed master PR (if applicable):

• [ONNX] Renable assert diagnostic test #85999

Link to release branch PR:

• [ONNX] Renable assert diagnostic test (#85999) #86924

Criteria Category:

• Test/CI

---

@malfet: merged, though it does not sound like a bugfix to me, more test/CI fixes

[BowenBao]

Link to landed master PR (if applicable):

• [ONNX] Fix triu/tril export with diagonal input #86843

Link to release branch PR:

• [ONNX] Fix triu/tril export with diagonal input (#86843) #86925

Criteria Category:

• bug fix, regression

---

@malfet: merged

[smk2007]

Link to landed master PR (if applicable):

• Allow PrivateUse1 backends to not have Storage #86557
• Fix incorrect tensor storage check  #86845

Link to release branch PR:

• Allow PrivateUse1 backends to not have Storage (#86557) #86803

Criteria Category:
Fix required for enabling the DirectML out-of-tree backend plugin in 1.13.

---

@malfet: merged

[samdow]

Link to landed master PR (if applicable):

• add deprecation warning to nn stateless functional_call #87367

Link to release branch PR:

• [release] Add warning to stateless.functional_call for deprecated behavior #87079

Criteria Category:

• Fixes silent correctness issue (users shouldn't be able to do this and we'll break it in future versions)

---

@atalman merged

[atalman]

Link to landed master PR (if applicable):

• Reenable aot tests on windows for cuda 11.7 and up #87193

Link to release branch PR:

• Reenable aot tests on windows for cuda 11.7 and up (#87193) #87307

Criteria Category:

• CI - Adds more tests

---

@malfet: Merged. I don't think it's a critical CI fix(as it does not fix anything, just adds more testing), but any new tests can go into the branch

[mikaylagawarecki]

Link to landed master PR (if applicable):

• Improve NestedTensor documentation #85186

Link to release branch PR:

• Improve NestedTensor documentation (#85186) #87337

Criteria Category:

• Documentation improvement

---

@atalman merged

[cpuhrsch]

Link to landed master PR:

• Add torch.sparse overview section #85265

Link to release branch PR:

• Add torch.sparse overview section (#85265) #87376

Criteria Category

• Documentation improvement

---

@atalman merged

[cpuhrsch]

Link to landed master PR:

• [Docs] Update mm family ops and F.linear to note limited sparse support.  #86220

Link to release branch PR:

• [Docs] Update mm family ops and F.linear to note limited sparse support. (#86220) #87379

Criteria Category

• Documentation improvement

---

@atalman Merged

[cpuhrsch]

Link to landed master PR:

• Add prototype warning to MaskedTensor constructor #87107

Link to release branch PR:

• Add prototype warning to MaskedTensor constructor (#87107) #87380

Criteria Category

• Documentation improvement / code warning (not exactly sure)

---

@atalman merged

[cpuhrsch]

Link to landed master PR:

• [maskedtensor] add docs #84887

Link to release branch PR:

• [maskedtensor] add docs (#84887) #87381

Criteria Category

• Documentation improvement

---

@atalman merged

[zrphercule]

Link to landed master PR:

• Assert if padding mask type is unexpected (#86353) #87106

Link to release branch PR:

• Assert if padding mask type is unexpected (#87106) #87384

Criteria Category

• Fixed asserting bugs in Transformer & added unit test
• Documentation improvement

---

@malfet merged

[zou3519]

Link to landed master PR (if applicable):

• [functorch][docs] Downgrade the warning about forward-mode AD coverage #87383

Link to release branch PR:

• [functorch][docs] Downgrade the warning about forward-mode AD coverag… #87386

Criteria Category:

• 5. Documentation improvements

---

@atalman merged

[zou3519]

Link to landed master PR (if applicable):

• n/a

Link to release branch PR:

• [1.13] Fix functorch version docs #87392

Criteria Category:

• Release branch specific changes. The functorch docs build is not showing the correct version on the release branch. This PR fixes it.

---

@atalman merged

[george-qi]

Link to landed master PR (if applicable):

• [maskedtensor] fix docs formatting #87387

Link to release branch PR:

• [maskedtensor] fix docs formatting (#87387) #87406

Criteria Category:

• Documentation improvement

---

@atalman merged

[atalman]

Link to landed master PR (if applicable):

• [ci] handle libomp upgrade on github #87382

Link to release branch PR:

• [ci] handle libomp upgrade on github (#87382) #87408

Criteria Category:

• CI keep signal green

---

@malfet: merged

[malfet]

Link to the landed master PR:

• [MPS] Do not dispatch empty job in bitwise_not #87286

Link to the release branch PR:

• [MPS] Do not dispatch empty job in bitwise_not (#87286) #87427

Criteria Category:

• 2. Critical fixes for crashes (crashes on x86 Mac when bitwise not is used on an empty tensor)

---

@malfet: merged

[zou3519]

Link to landed master PR (if applicable):

• [functorch] fix AOTAutograd tutorial #87415

Link to release branch PR:

• [functorch] fix AOTAutograd tutorial (#87415) #87434

Criteria Category:

• Documentation improvements

---

@malfet: merged

[malfet]

Link to landed master PRs:

• Tweak several test serialization to store models state_dict #87143
• Add weights_only option to torch.load #86812

Link to release branch PR:

• Add weights_only option to torch.load #87443

Criteria Category: Special dispensation (Addressing security concern), needs to be confirmed

---

@atalman merged

[atalman]

Link to landed master PR (if applicable):

• Delete torch::deploy from pytorch core #85953

Link to release branch PR:

• Delete torch::deploy from pytorch core (#85953) (#85953) #87454

Criteria Category:

• Test/CI fixes

---

@malfet: merged

[atalman]

Link to landed master PR (if applicable):

• Avoid calling logging.basicConfig #86959

Link to release branch PR:

• Avoid calling logging.basicConfig (#86959) #87455

Criteria Category:

• Critical fix

---

@atalman merged

[atalman]

Link to landed master PR (if applicable):

• Move PadNd from ATen/native to ATen #82379

Link to release branch PR:

• Move PadNd from ATen/native to ATen #87456

Criteria Category:

• Critical Fix

---

@malfet: merged

[atalman]

Link to landed master PR (if applicable):

• [ONNX] Reland: Update training state logic to support ScriptedModule #86745

Link to release branch PR:

• [ONNX] Reland: Update training state logic to support ScriptedModule … #87457

Criteria Category:

• Critical Fix

---

@malfet: merged

[atalman]

Link to landed master PR (if applicable):

• Reenable isinstance with torch.distributed.ReduceOp #87303

Link to release branch PR:

• Reenable isinstance with torch.distributed.ReduceOp (#87303) #87463

Criteria Category:

• Critical fix

---

@malfet: merged

[malfet]

Link to landed master PRs:

• [MPS] Copy from CPU always add storageOffset #86958
• [MPS] Revamp copy_to_mps_ implementation #86956

Link to release branch PR:

• [MPS] Revamp copy_to_mps_ implementation #87475

Criteria Category:

• Critical fixes for silent correctness

---

@malfet merged

[atalman]

Final RC have been generated. We don't Accept cherry-picks anymore. Please don't post any cherry-picks.

[atalman]

Link to landed master PR (if applicable):

• Add General Project Policies #87385

Link to release branch PR:

• Add General Project Policies (#87385) #87613

Criteria Category:

• Documentation

---

@atalman merged

[atalman]

Link to landed master PR (if applicable):

• Fix distributed issue by including distributed files #87615

Link to release branch PR:

• Fix distributed issue by including distributed files #87612

Criteria Category:

• Critical distributed fix

---

@atalman merged

[atalman]

Link to landed master PR (if applicable):

• attempted fix for nvrtc with lovelace #87611

Link to release branch PR:

• attempted fix for nvrtc with lovelace (#87611) #87618

Criteria Category:

• Critical CUDA/nvrtc fix

---

@atalman merged

[atalman]

Link to landed master PR (if applicable):

• fix docs push #87498

Link to release branch PR:

• fix docs push (#87498) #87628

Criteria Category:

• CI/CD documentation push

---

@atalman merged

[malfet]

1.13.0 has been published, closing this one.