Support autograd on Linear with sparse compressed weight. #86137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86137
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 FailuresAs of commit 05c68b2: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pearu
added a commit
that referenced
this pull request
Oct 3, 2022
ghstack-source-id: 9fe702d7887277945905967921b68f6e278af837 Pull Request resolved: #86137
|
@soulitzer you can handle that one? |
|
/easycla As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details. This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign. |
pearu
commented
Oct 4, 2022
Comment on lines
+461
to
+466
| switch(input_.layout()) { | ||
| case kSparseCsr: return grad.sparse_mask(input_.to_sparse()).to_sparse_csr(); | ||
| case kSparseCsc: return grad.sparse_mask(input_.to_sparse()).to_sparse_csc(); | ||
| // BSR and BSC should be handled via implement sparse_compressed_mask | ||
| default: ; // fall back to unsupported input layout error | ||
| } |
There was a problem hiding this comment.
After resolving #80542, this could be replaced by
return grad.sparse_mask(input_.to_sparse()).to(input_.layout());[ghstack-poisoned]
pearu
added a commit
that referenced
this pull request
Oct 4, 2022
ghstack-source-id: 2eb0d3d2146ddd890ee4baa836868db6afdbc73a Pull Request resolved: #86137
[ghstack-poisoned]
pearu
added a commit
that referenced
this pull request
Oct 4, 2022
ghstack-source-id: 50aa539aad890c295bdf31d83233a4d57d4466d0 Pull Request resolved: #86137
[ghstack-poisoned]
[ghstack-poisoned]
This was referenced Oct 5, 2022
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
cpuhrsch
reviewed
Oct 6, 2022
cpuhrsch
approved these changes
Oct 6, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
…86137) Summary: Pull Request resolved: #86137 Approved by: https://github.com/cpuhrsch Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f104490d635747e4164e954d36954ea3a01731a5 Reviewed By: seemethere Differential Revision: D40167118 Pulled By: seemethere fbshipit-source-id: 2b61f89c7ba514e29acbf91fce5c02097198cf21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @alexsamardzic @nikitaved @cpuhrsch @amjames @bhosmer