Support sum on a sparse COO tensor. #86300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86300
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Failures, 2 PendingAs of commit 6ae8a14: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 5, 2022
[ghstack-poisoned]
pearu
added
module: sparse
|
Related: #86232 If sum is supported by direct dispatch (only as sparse_coo_tensor.sum() or also as torch.sum(sparse_coo_tensor)? If so, then is torch.sparse.sum still needed? |
We are not quite there yet. This PR implements support for the sum over all values but we'll also need to implement the support for |
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
cpuhrsch
approved these changes
Oct 6, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
Summary: Pull Request resolved: #86300 Approved by: https://github.com/cpuhrsch Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/88b882cd1c93e8fe9b4f2bf0c542c700a8ba69a6 Reviewed By: seemethere Differential Revision: D40167132 Pulled By: seemethere fbshipit-source-id: ea8af116fc65cd1f7280046b824415b055aab61e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @alexsamardzic @nikitaved @cpuhrsch @amjames @bhosmer