Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Update mm family ops and F.linear to note limited sparse support. #86220

Closed
wants to merge 6 commits into from
Closed

[Docs] Update mm family ops and F.linear to note limited sparse support. #86220

wants to merge 6 commits into from

Conversation

amjames
Copy link
Collaborator

@amjames amjames commented Oct 4, 2022

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 4, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86220

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures, 1 Pending

As of commit 8fb306e:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

cpuhrsch
cpuhrsch reviewed Oct 4, 2022
View reviewed changes
torch/_torch_docs.py Outdated Show resolved Hide resolved
@amjames amjames marked this pull request as ready for review October 5, 2022 21:31
@amjames amjames changed the title [WIP] Update mm family ops and F.linear to note limited sparse support. [Docs] Update mm family ops and F.linear to note limited sparse support. Oct 6, 2022
@amjames amjames added the module: sparse Related to torch.sparse label Oct 6, 2022
@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 6, 2022
cpuhrsch
cpuhrsch reviewed Oct 15, 2022
View reviewed changes
torch/_torch_docs.py Outdated Show resolved Hide resolved
cpuhrsch
cpuhrsch approved these changes Oct 15, 2022
View reviewed changes
Copy link
Contributor

@cpuhrsch cpuhrsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one last comment about the link left. Thanks!

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 15, 2022
@albanD albanD removed their request for review October 16, 2022 15:47
@amjames
Copy link
Collaborator Author

amjames commented Oct 18, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 additional jobs have failed, first few of them are: trunk

Details for Dev Infra team Raised by workflow job

@amjames
Copy link
Collaborator Author

amjames commented Oct 18, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link

Hey @amjames.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@cpuhrsch cpuhrsch added the topic: docs topic category label Oct 18, 2022
cpuhrsch pushed a commit to cpuhrsch/pytorch that referenced this pull request Oct 20, 2022
@amjames @cpuhrsch
[Docs] Update mm family ops and F.linear to note limited sparse suppo…
08971f5 
…rt. (pytorch#86220)

Pull Request resolved: pytorch#86220
Approved by: https://github.com/cpuhrsch
This was referenced Oct 20, 2022
Merged
Closed
atalman pushed a commit that referenced this pull request Oct 20, 2022
@cpuhrsch @amjames
[Docs] Update mm family ops and F.linear to note limited sparse suppo…
1f80ac7 
…rt. (#86220) (#87379)

Pull Request resolved: #86220
Approved by: https://github.com/cpuhrsch

Co-authored-by: Andrew M. James <andrew.m.james2@gmail.com>
@malfet malfet mentioned this pull request Nov 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuhrsch cpuhrsch cpuhrsch approved these changes

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged module: sparse Related to torch.sparse open source topic: docs topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@amjames @pytorchmergebot @cpuhrsch @facebook-github-bot @bdhirsh @pytorchbot