Fix for binary upload step, use bash shell rather then default sh #86382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86382
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1bfd24e: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
atalman
added
the
ciflow/binaries_conda
atalman
force-pushed
the
test_fix_upload
branch
from
f9af920
to
1bfd24e
Compare
atalman
changed the title
|
@pytorchmergebot merge -f "This is CI binaries nightly change" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
…6382) (#86382) Summary: This fixes the issue during upload: ``` Run # reference ends with an RC suffix # reference ends with an RC suffix if [[ ${GITHUB_REF_NAME} = *-rc[0-9]* ]]; then echo "UPLOAD_CHANNEL=test" >> "$GITHUB_ENV" fi shell: sh -e {0} /__w/_temp/f045f5d8-ddb.sh: 2: [[: not found ``` Test failure: https://github.com/pytorch/pytorch/actions/runs/3199561387/jobs/5225448559 Test success: https://github.com/pytorch/pytorch/actions/runs/3199573560/jobs/5225480345 Error started when we switched to: continuumio/miniconda3:4.12.0 Pull Request resolved: #86382 Approved by: https://github.com/weiwangmeta Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/bf746798841bd42c9b849716f9eeefde3271e93d Reviewed By: seemethere Differential Revision: D40167171 Pulled By: seemethere fbshipit-source-id: d18689b94b06d02dd12c6159b29df54de9e3699e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue during upload:
Test failure:
https://github.com/pytorch/pytorch/actions/runs/3199561387/jobs/5225448559
Test success:
https://github.com/pytorch/pytorch/actions/runs/3199573560/jobs/5225480345
Error started when we switched to: continuumio/miniconda3:4.12.0