Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version selector back to functorch docs #86602

Closed
wants to merge 1 commit into from

Conversation

zou3519
Copy link
Contributor

@zou3519 zou3519 commented Oct 10, 2022

Stack from ghstack:

I accidentally deleted it in
#85856 . This brings the version
selector back.

I accidentally deleted it in
#85856 . This brings the version
selector back.

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 10, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86602

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7717d81:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

zou3519 added a commit that referenced this pull request Oct 10, 2022
I accidentally deleted it in
#85856 . This brings the version
selector back.

ghstack-source-id: 3186bdad95470c6c56b2b0cb13bd41baffcd19b7
Pull Request resolved: #86602
@zou3519
Copy link
Contributor Author

zou3519 commented Oct 10, 2022

Note to self: this also needs to be cherry-picked to release branch

@zou3519
Copy link
Contributor Author

zou3519 commented Oct 10, 2022

Docs preview available at https://docs-preview.pytorch.org/86602/functorchdocs/index.html , note the version selector: (the triangle is clickable)

image

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 11, 2022
@samdow
Copy link
Contributor

samdow commented Oct 11, 2022

Wait I might have been premature in my approve haha
Is this what we're trying to fix? I still see this in the docs build from this PR?

No dropdown
Screen Shot 2022-10-11 at 10 42 04 AM
Previous version has dropdown
Screen Shot 2022-10-11 at 10 42 53 AM

Edit: nvm I was looking at the wrong version. It looks fine on the docs preview build

@zou3519
Copy link
Contributor Author

zou3519 commented Oct 11, 2022

Yeah, the previous version of the nightly docs have no dropdown. In the preview for this PR, there is a dropdown.

All the stable docs (0.2.1, etc) are built a single time and never updated so they aren't affected.

@zou3519
Copy link
Contributor Author

zou3519 commented Oct 11, 2022

@pytorchbot merge -f "docs-only change; docs CI ran already"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link

Hey @zou3519.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

zou3519 added a commit that referenced this pull request Oct 11, 2022
I accidentally deleted it in
#85856 . This brings the version
selector back.
Pull Request resolved: #86602
Approved by: https://github.com/samdow
atalman pushed a commit that referenced this pull request Oct 12, 2022
I accidentally deleted it in
#85856 . This brings the version
selector back.
Pull Request resolved: #86602
Approved by: https://github.com/samdow
@facebook-github-bot facebook-github-bot deleted the gh/zou3519/549/head branch June 8, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants