Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

symintify autograd view chaining #86604

Closed
wants to merge 2 commits into from
Closed

symintify autograd view chaining #86604

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b422147
symintify autograd view chaining
albanD Oct 10, 2022
4397fab
Update on "symintify autograd view chaining"
albanD Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions torch/csrc/autograd/variable.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,11 @@ ViewInfo ViewInfo::chain(
} else {
// current_view has a view_func and but it's parent doesn't have one
if (base.unsafeGetTensorImpl()->support_as_strided()) {
auto size = base.sizes().vec();
auto stride = base.strides().vec();
auto storage_offset = base.storage_offset();
auto size = base.sym_sizes().vec();
auto stride = base.sym_strides().vec();
auto storage_offset = base.sym_storage_offset();
view_func = [=](const at::Tensor& root_base) {
auto temp = root_base.as_strided(size, stride, storage_offset);
auto temp = root_base.as_strided_symint(size, stride, storage_offset);
return view_func(temp);
};
} else {
Expand All @@ -111,12 +111,12 @@ ViewInfo ViewInfo::chain(
// if current_view doesn't have a view_func but it's parent has one
// Copy parent view function to gain ownership
auto prev_view_fn = view_fn_;
auto size = tensor.sizes().vec();
auto stride = tensor.strides().vec();
auto storage_offset = tensor.storage_offset();
auto size = tensor.sym_sizes().vec();
auto stride = tensor.sym_strides().vec();
auto storage_offset = tensor.sym_storage_offset();
view_func = [=](const at::Tensor& root_base) {
auto temp = prev_view_fn(root_base);
return temp.as_strided(size, stride, storage_offset);
return temp.as_strided_symint(size, stride, storage_offset);
};
}

Expand Down