Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.13] Release-only improvements to functorch docs #86693

Merged
merged 1 commit into from Oct 13, 2022
Merged

[1.13] Release-only improvements to functorch docs #86693

merged 1 commit into from Oct 13, 2022

Conversation

zou3519
Copy link
Contributor

@zou3519 zou3519 commented Oct 11, 2022

This PR:

  • corrects the functorch version string (previously it said "nightly", it should instead say the version, which is 1.13).
  • Adds permalinks to colabs. The colab notebooks previously linked to the ones on the master branch, instead, they should link to the ones on the release/1.13 branch.

Test Plan:

  • build and tested docs locally

Fixes #ISSUE_NUMBER

@zou3519
[1.13] Release-only improvements to functorch docs
9960ce1 
This PR:
- corrects the functorch version string (previously it said "nightly",
it should instead say the version, which is 1.13).
- Adds permalinks to colabs. The colab notebooks previously linked to
the ones on the master branch, instead, they should link to the ones on
the release/1.13 branch.

Test Plan:
- build and tested docs locally
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 11, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86693

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit 9960ce1:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@zou3519 zou3519 mentioned this pull request Oct 11, 2022
Closed
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 13, 2022
@malfet malfet merged commit 0104248 into release/1.13 Oct 13, 2022
@malfet malfet deleted the 1_13_functorch_docs_improvements branch October 13, 2022 14:21
@malfet malfet mentioned this pull request Nov 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

@atalman atalman atalman approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zou3519 @malfet @atalman