Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPS] Do not dispatch empty job in bitwise_not #87286

Closed
wants to merge 1 commit into from
Closed

[MPS] Do not dispatch empty job in bitwise_not #87286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion aten/src/ATen/native/mps/operations/BitwiseOps.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,14 +302,17 @@ void handle_tensor_scalar_binary_op(const at::Tensor& self, const at::Scalar& ot
}
return output_;
}
uint32_t length = output.numel();
if (length == 0) {
return output_;
}
using namespace at::mps;
MPSStream* stream = getCurrentMPSStream();
id<MTLComputePipelineState> cplState = getCPLState(MPSDevice::getInstance()->device(),
getMetalType(output),
getMetalType(self),
getMetalType(self),
"bitwise_not");
uint32_t length = output.numel();
dispatch_sync(stream->queue(), ^(){
id<MTLCommandBuffer> buffer = stream->commandBuffer();
id<MTLComputeCommandEncoder> commandEncoder = [buffer computeCommandEncoder];
Expand Down