Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPS] Do not dispatch empty job in bitwise_not #87286

Closed
wants to merge 1 commit into from
Closed

[MPS] Do not dispatch empty job in bitwise_not #87286

wants to merge 1 commit into from
+4 −1

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Oct 19, 2022

Follows the pattern from #85285 and returns before computing dispatching an empty metal kernel for bitwise not operation.

Fixes crash when invoked with empty MPS tensor on AMD GPU

@malfet
[MPS] Do not dispatch empty job in bitwise_not
53af3b7 
Follows the pattern from #85285 and returns before computing dispatching an empty metal kernel for bitwise not operation.

Fixes crash when invoked with empty MPS tensor on AMD GPU
@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Oct 19, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 19, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87286

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures, 3 Pending

As of commit 53af3b7:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet malfet added this to the 1.13.0 milestone Oct 19, 2022
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 19, 2022
@kulinseth
Copy link
Collaborator

Can we get this in 1.13 as well

@malfet
Copy link
Contributor Author

malfet commented Oct 19, 2022

@pytorchbot merge -f "MPS tests are green, rest of the signal is noise"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link

Hey @malfet.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@malfet malfet mentioned this pull request Oct 20, 2022
Merged
malfet added a commit that referenced this pull request Oct 20, 2022
@malfet
[MPS] Do not dispatch empty job in bitwise_not (#87286)
659e47b 
Follows the pattern from #85285 and returns before computing dispatching an empty metal kernel for bitwise not operation.

Fixes crash when invoked with empty MPS tensor on AMD GPU

Pull Request resolved: #87286
Approved by: https://github.com/kulinseth

(cherry picked from commit a79e034)
@malfet malfet mentioned this pull request Oct 20, 2022
Closed
malfet added a commit that referenced this pull request Oct 21, 2022
@malfet
[MPS] Do not dispatch empty job in bitwise_not (#87286) (#87427)
05cb998 
Follows the pattern from #85285 and returns before computing dispatching an empty metal kernel for bitwise not operation.

Fixes crash when invoked with empty MPS tensor on AMD GPU

Pull Request resolved: #87286
Approved by: https://github.com/kulinseth

(cherry picked from commit a79e034)
sgrigory pushed a commit to sgrigory/pytorch that referenced this pull request Oct 28, 2022
@malfet @sgrigory
[MPS] Do not dispatch empty job in bitwise_not (pytorch#87286)
8bd473c 
Follows the pattern from pytorch#85285 and returns before computing dispatching an empty metal kernel for bitwise not operation.

Fixes crash when invoked with empty MPS tensor on AMD GPU

Pull Request resolved: pytorch#87286
Approved by: https://github.com/kulinseth
@malfet malfet deleted the malfet-patch-17 branch November 4, 2022 04:30
@malfet malfet mentioned this pull request Nov 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulinseth kulinseth kulinseth approved these changes

Assignees
No one assigned
Labels
ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: mps Release notes category
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@malfet @kulinseth @pytorchmergebot