Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add deprecation warning to nn stateless functional_call #87367

Closed
wants to merge 2 commits into from
Closed

add deprecation warning to nn stateless functional_call #87367

wants to merge 2 commits into from

Conversation

samdow
Copy link
Contributor

@samdow samdow commented Oct 20, 2022 •
edited

Same as the release version but just for master

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 20, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87367

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures, 1 Pending

As of commit d64119d:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

samdow pushed a commit that referenced this pull request Oct 20, 2022
add deprecation warning to nn stateless
22727ed 
ghstack-source-id: 888e318616a784a76c1ed51a08f18e6e19f9c256
Pull Request resolved: #87367
@samdow samdow changed the title add deprecation warning to nn stateless add deprecation warning to nn stateless functional_call Oct 20, 2022
@samdow samdow mentioned this pull request Oct 20, 2022
Closed
Update on "add deprecation warning to nn stateless functional_call"
d64119d 
Same as the release version but just for master




[ghstack-poisoned]
samdow pushed a commit that referenced this pull request Oct 20, 2022
add deprecation warning to nn stateless
549588d 
ghstack-source-id: ecd5b49f2ea35b170a144c57f9d135e5947be703
Pull Request resolved: #87367
albanD
albanD approved these changes Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 20, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

atalman
atalman approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samdow
Copy link
Contributor Author

samdow commented Oct 20, 2022

@pytorchbot merge -f "need for release"

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link

Hey @samdow.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@samdow samdow added release notes: nn release notes category topic: deprecation topic category labels Oct 20, 2022
sgrigory pushed a commit to sgrigory/pytorch that referenced this pull request Oct 28, 2022
@sgrigory
add deprecation warning to nn stateless functional_call (pytorch#87367)
ce4ce93 
Same as the release version but just for master

Pull Request resolved: pytorch#87367
Approved by: https://github.com/albanD, https://github.com/atalman
@facebook-github-bot facebook-github-bot deleted the gh/samdow/37/head branch June 8, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

@atalman atalman atalman approved these changes

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: nn release notes category topic: deprecation topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@samdow @pytorchmergebot @albanD @atalman