Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nn] add remove_duplicate flag to named_parameters (#759) #88090

Closed
wants to merge 1 commit into from
Closed

[nn] add remove_duplicate flag to named_parameters (#759) #88090

wants to merge 1 commit into from

Conversation

samdow
Copy link
Contributor

@samdow samdow commented Oct 31, 2022 •
edited by pytorch-bot bot

Summary:
X-link: pytorch/torchrec#759

Since the remove_duplicate flag was added to named_buffers in D39493161 (c12f829), this adds the same flag to named_parameters

Test Plan:
python test/test_nn.py -k test_buffers_and_named_buffers

OSS Tests

Differential Revision: D40801899

cc @ezyang @gchanan

@pytorch-bot pytorch-bot bot added the release notes: nn release notes category label Oct 31, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 31, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88090

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 259e061:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40801899

albanD
albanD approved these changes Oct 31, 2022
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Just an extra test.

test/test_nn.py Outdated Show resolved Hide resolved
torch/nn/modules/module.py
self,
prefix: str = '',
recurse: bool = True,
remove_duplicate: bool = True
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can't make these kwarg only? :(

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 31, 2022
samdow added a commit to samdow/torchrec that referenced this pull request Nov 1, 2022
@samdow @facebook-github-bot
add remove_duplicate flag to named_parameters (#88090)
123a869 
Summary:
X-link: pytorch/pytorch#88090

Pull Request resolved: pytorch#759

Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@672d105), this adds the same flag to named_parameters

Differential Revision: D40801899

fbshipit-source-id: 083fc56e1b8064faf59e2ce4695741dfc150a5d5
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40801899

samdow added a commit to samdow/pytorch that referenced this pull request Nov 1, 2022
@samdow @facebook-github-bot
[nn] add remove_duplicate flag to named_parameters (pytorch#88090)
07c6333 
Summary:
Pull Request resolved: pytorch#88090

X-link: pytorch/torchrec#759

Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@c12f829), this adds the same flag to named_parameters

Test Plan:
python test/test_nn.py -k test_buffers_and_named_buffers

OSS Tests

Differential Revision: D40801899

fbshipit-source-id: 1b5eb2c4a4b51414256518f648faaff610f78e12
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40801899

samdow added a commit to samdow/pytorch that referenced this pull request Nov 1, 2022
@samdow @facebook-github-bot
[nn] add remove_duplicate flag to named_parameters (pytorch#88090)
58df794 
Summary:
Pull Request resolved: pytorch#88090

X-link: pytorch/torchrec#759

Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@c12f829), this adds the same flag to named_parameters

Test Plan:
python test/test_nn.py -k test_buffers_and_named_buffers

OSS Tests

Differential Revision: D40801899

fbshipit-source-id: ece48c40c17de93b5e0654ede4574870927fc2f1
samdow added a commit to samdow/torchrec that referenced this pull request Nov 1, 2022
@samdow @facebook-github-bot
add remove_duplicate flag to named_parameters (#88090)
d919eb0 
Summary:
X-link: pytorch/pytorch#88090

Pull Request resolved: pytorch#759

Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@672d105), this adds the same flag to named_parameters

Differential Revision: D40801899

fbshipit-source-id: 8676b5e5074924708f85d153cff7d20096a8c7a2
samdow added a commit to samdow/pytorch that referenced this pull request Nov 1, 2022
@samdow @facebook-github-bot
[nn] add remove_duplicate flag to named_parameters (pytorch#88090)
c00cab8 
Summary:
Pull Request resolved: pytorch#88090

X-link: pytorch/torchrec#759

Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@c12f829), this adds the same flag to named_parameters

Test Plan:
python test/test_nn.py -k test_buffers_and_named_buffers

OSS Tests

Differential Revision: D40801899

fbshipit-source-id: 51e8e0b00f8e6ca52f08d0752ab5b5838b74cd50
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40801899

samdow added a commit to samdow/torchrec that referenced this pull request Nov 7, 2022
@samdow @facebook-github-bot
add remove_duplicate flag to named_parameters (#88090)
9a5bd38 
Summary:
X-link: pytorch/pytorch#88090

Pull Request resolved: pytorch#759

Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@672d105), this adds the same flag to named_parameters

Reviewed By: albanD

Differential Revision: D40801899

fbshipit-source-id: 4b537c942650cbcbdfac57ba54040bbd2c0e29f7
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40801899

samdow added a commit to samdow/pytorch that referenced this pull request Nov 7, 2022
@samdow @facebook-github-bot
[nn] add remove_duplicate flag to named_parameters (pytorch#88090)
38e0475 
Summary:
Pull Request resolved: pytorch#88090

X-link: pytorch/torchrec#759

Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@c12f829), this adds the same flag to named_parameters

Test Plan:
python test/test_nn.py -k test_buffers_and_named_buffers

OSS Tests

Reviewed By: albanD

Differential Revision: D40801899

fbshipit-source-id: 872b28f2f0bfc667ec9065353d4db45c272a8064
samdow added a commit to samdow/torchrec that referenced this pull request Nov 7, 2022
@samdow @facebook-github-bot
add remove_duplicate flag to named_parameters (#88090)
d6074d3 
Summary:
X-link: pytorch/pytorch#88090

Pull Request resolved: pytorch#759

Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@672d105), this adds the same flag to named_parameters

Reviewed By: albanD

Differential Revision: D40801899

fbshipit-source-id: 726ea2fd62dda164d0bd7616a85ce7eb1d473507
samdow added a commit to samdow/pytorch that referenced this pull request Nov 7, 2022
@samdow @facebook-github-bot
[nn] add remove_duplicate flag to named_parameters (pytorch#88090)
814d756 
Summary:
Pull Request resolved: pytorch#88090

X-link: pytorch/torchrec#759

Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@c12f829), this adds the same flag to named_parameters

Test Plan:
python test/test_nn.py -k test_buffers_and_named_buffers

OSS Tests

Reviewed By: albanD

Differential Revision: D40801899

fbshipit-source-id: 64b42977ccaf231c03b524d54826e35104c630c9
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40801899

samdow added a commit to samdow/torchrec that referenced this pull request Nov 7, 2022
@samdow @facebook-github-bot
add remove_duplicate flag to named_parameters (#88090)
57c5116 
Summary:
X-link: pytorch/pytorch#88090

Pull Request resolved: pytorch#759

Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@672d105), this adds the same flag to named_parameters

Reviewed By: albanD

Differential Revision: D40801899

fbshipit-source-id: 3b195a4c00c38636ccddf7313c0dc3ea976f0ad5
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40801899

samdow added a commit to samdow/pytorch that referenced this pull request Nov 7, 2022
@samdow @facebook-github-bot
[nn] add remove_duplicate flag to named_parameters (pytorch#88090)
d514e41 
Summary:
Pull Request resolved: pytorch#88090

X-link: pytorch/torchrec#759

Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@c12f829), this adds the same flag to named_parameters

Test Plan:
python test/test_nn.py -k test_buffers_and_named_buffers

OSS Tests

Reviewed By: albanD

Differential Revision: D40801899

fbshipit-source-id: 2553cceecae1f37c544275d9841dff0097494813
samdow added a commit to samdow/torchrec that referenced this pull request Nov 7, 2022
@samdow @facebook-github-bot
add remove_duplicate flag to named_parameters (#88090)
b52a1e0 
Summary:
X-link: pytorch/pytorch#88090

Pull Request resolved: pytorch#759

Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@672d105), this adds the same flag to named_parameters

Reviewed By: albanD

Differential Revision: D40801899

fbshipit-source-id: 2adc53cebb5658c639b429bab24d69a106959ff6
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40801899

samdow added a commit to samdow/pytorch that referenced this pull request Nov 7, 2022
@samdow @facebook-github-bot
[nn] add remove_duplicate flag to named_parameters (pytorch#88090)
28ca878 
Summary:
Pull Request resolved: pytorch#88090

X-link: pytorch/torchrec#759

Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@c12f829), this adds the same flag to named_parameters

Test Plan:
python test/test_nn.py -k test_buffers_and_named_buffers

OSS Tests

Reviewed By: albanD

Differential Revision: D40801899

fbshipit-source-id: 99aad6bb4b4876a81a6a92785f3e40a1c006538a
@samdow @facebook-github-bot
[nn] add remove_duplicate flag to named_parameters (pytorch#88090)
259e061 
Summary:
Pull Request resolved: pytorch#88090

X-link: pytorch/torchrec#759

Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@c12f829), this adds the same flag to named_parameters

Test Plan:
python test/test_nn.py -k test_buffers_and_named_buffers

OSS Tests

Reviewed By: albanD

Differential Revision: D40801899

fbshipit-source-id: 163bfd5052c42b9bd87cb35931d9f7be627e3256
samdow added a commit to samdow/torchrec that referenced this pull request Nov 8, 2022
@samdow @facebook-github-bot
add remove_duplicate flag to named_parameters (#88090)
513ecfb 
Summary:
X-link: pytorch/pytorch#88090

Pull Request resolved: pytorch#759

Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@672d105), this adds the same flag to named_parameters

Reviewed By: albanD

Differential Revision: D40801899

fbshipit-source-id: 89ab659ebdc2f916e62609f6e793d426b3a4518b
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40801899

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

facebook-github-bot pushed a commit to pytorch/torchrec that referenced this pull request Nov 9, 2022
@samdow @facebook-github-bot
add remove_duplicate flag to named_parameters (#88090)
d18156e 
Summary:
X-link: pytorch/pytorch#88090

Pull Request resolved: #759

Since the remove_duplicate flag was added to named_buffers in D39493161 (672d105), this adds the same flag to named_parameters

Reviewed By: albanD

Differential Revision: D40801899

fbshipit-source-id: 5318259adc6e3c487ccd95aeefecf0a02a1ce79d
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

lequytra pushed a commit to lequytra/torchrec that referenced this pull request Dec 6, 2022
@samdow @lequytra
add remove_duplicate flag to named_parameters (#88090)
b6a2541 
Summary:
X-link: pytorch/pytorch#88090

Pull Request resolved: pytorch#759

Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@672d105), this adds the same flag to named_parameters

Reviewed By: albanD

Differential Revision: D40801899

fbshipit-source-id: 5318259adc6e3c487ccd95aeefecf0a02a1ce79d
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@samdow @kulinseth
[nn] add remove_duplicate flag to named_parameters (pytorch#759) (pyt…
db8b55b 
…orch#88090)

Summary:
X-link: pytorch/torchrec#759

Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@c12f829), this adds the same flag to named_parameters

Test Plan:
python test/test_nn.py -k test_buffers_and_named_buffers

OSS Tests

Differential Revision: D40801899

Pull Request resolved: pytorch#88090
Approved by: https://github.com/albanD
@zou3519 zou3519 added module: bc-breaking Related to a BC-breaking change topic: bc breaking topic category labels Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: bc-breaking Related to a BC-breaking change release notes: nn release notes category topic: bc breaking topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@samdow @facebook-github-bot @pytorchmergebot @albanD @zou3519