add remove_duplicate flag to named_parameters #759
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D40801899 |
samdow
added a commit
to samdow/torchrec
that referenced
this pull request
Oct 31, 2022
Summary: Pull Request resolved: pytorch#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@672d105), this adds the same flag to named_parameters Differential Revision: D40801899 fbshipit-source-id: a01807c81f0069ea02bdb95d3f937d458f3d9a5d
samdow
force-pushed
the
export-D40801899
branch
from
cdaaac6
to
468c379
Compare
|
This pull request was exported from Phabricator. Differential Revision: D40801899 |
samdow
added a commit
to samdow/pytorch
that referenced
this pull request
Oct 31, 2022
Summary: X-link: pytorch/torchrec#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@c12f829), this adds the same flag to named_parameters Test Plan: python test/test_nn.py -k test_buffers_and_named_buffers OSS Tests Differential Revision: D40801899 fbshipit-source-id: d3054bd9659d6f63f22a1d55fb0dc8898674ad87
samdow
added a commit
to samdow/torchrec
that referenced
this pull request
Nov 1, 2022
Summary: X-link: pytorch/pytorch#88090 Pull Request resolved: pytorch#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@672d105), this adds the same flag to named_parameters Differential Revision: D40801899 fbshipit-source-id: 083fc56e1b8064faf59e2ce4695741dfc150a5d5
|
This pull request was exported from Phabricator. Differential Revision: D40801899 |
samdow
force-pushed
the
export-D40801899
branch
from
468c379
to
123a869
Compare
samdow
added a commit
to samdow/pytorch
that referenced
this pull request
Nov 1, 2022
Summary: Pull Request resolved: pytorch#88090 X-link: pytorch/torchrec#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@c12f829), this adds the same flag to named_parameters Test Plan: python test/test_nn.py -k test_buffers_and_named_buffers OSS Tests Differential Revision: D40801899 fbshipit-source-id: 1b5eb2c4a4b51414256518f648faaff610f78e12
samdow
added a commit
to samdow/pytorch
that referenced
this pull request
Nov 1, 2022
Summary: Pull Request resolved: pytorch#88090 X-link: pytorch/torchrec#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@c12f829), this adds the same flag to named_parameters Test Plan: python test/test_nn.py -k test_buffers_and_named_buffers OSS Tests Differential Revision: D40801899 fbshipit-source-id: ece48c40c17de93b5e0654ede4574870927fc2f1
samdow
added a commit
to samdow/torchrec
that referenced
this pull request
Nov 1, 2022
Summary: X-link: pytorch/pytorch#88090 Pull Request resolved: pytorch#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@672d105), this adds the same flag to named_parameters Differential Revision: D40801899 fbshipit-source-id: 8676b5e5074924708f85d153cff7d20096a8c7a2
|
This pull request was exported from Phabricator. Differential Revision: D40801899 |
samdow
force-pushed
the
export-D40801899
branch
from
123a869
to
d919eb0
Compare
samdow
added a commit
to samdow/pytorch
that referenced
this pull request
Nov 1, 2022
Summary: Pull Request resolved: pytorch#88090 X-link: pytorch/torchrec#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@c12f829), this adds the same flag to named_parameters Test Plan: python test/test_nn.py -k test_buffers_and_named_buffers OSS Tests Differential Revision: D40801899 fbshipit-source-id: 51e8e0b00f8e6ca52f08d0752ab5b5838b74cd50
|
This pull request was exported from Phabricator. Differential Revision: D40801899 |
samdow
force-pushed
the
export-D40801899
branch
from
d919eb0
to
9a5bd38
Compare
samdow
added a commit
to samdow/torchrec
that referenced
this pull request
Nov 7, 2022
Summary: X-link: pytorch/pytorch#88090 Pull Request resolved: pytorch#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@672d105), this adds the same flag to named_parameters Reviewed By: albanD Differential Revision: D40801899 fbshipit-source-id: 4b537c942650cbcbdfac57ba54040bbd2c0e29f7
samdow
added a commit
to samdow/pytorch
that referenced
this pull request
Nov 7, 2022
Summary: Pull Request resolved: pytorch#88090 X-link: pytorch/torchrec#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@c12f829), this adds the same flag to named_parameters Test Plan: python test/test_nn.py -k test_buffers_and_named_buffers OSS Tests Reviewed By: albanD Differential Revision: D40801899 fbshipit-source-id: 872b28f2f0bfc667ec9065353d4db45c272a8064
|
This pull request was exported from Phabricator. Differential Revision: D40801899 |
samdow
added a commit
to samdow/torchrec
that referenced
this pull request
Nov 7, 2022
Summary: X-link: pytorch/pytorch#88090 Pull Request resolved: pytorch#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@672d105), this adds the same flag to named_parameters Reviewed By: albanD Differential Revision: D40801899 fbshipit-source-id: 726ea2fd62dda164d0bd7616a85ce7eb1d473507
samdow
force-pushed
the
export-D40801899
branch
from
9a5bd38
to
d6074d3
Compare
samdow
added a commit
to samdow/pytorch
that referenced
this pull request
Nov 7, 2022
Summary: Pull Request resolved: pytorch#88090 X-link: pytorch/torchrec#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@c12f829), this adds the same flag to named_parameters Test Plan: python test/test_nn.py -k test_buffers_and_named_buffers OSS Tests Reviewed By: albanD Differential Revision: D40801899 fbshipit-source-id: 64b42977ccaf231c03b524d54826e35104c630c9
samdow
added a commit
to samdow/torchrec
that referenced
this pull request
Nov 7, 2022
Summary: X-link: pytorch/pytorch#88090 Pull Request resolved: pytorch#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@672d105), this adds the same flag to named_parameters Reviewed By: albanD Differential Revision: D40801899 fbshipit-source-id: 3b195a4c00c38636ccddf7313c0dc3ea976f0ad5
samdow
force-pushed
the
export-D40801899
branch
from
d6074d3
to
57c5116
Compare
|
This pull request was exported from Phabricator. Differential Revision: D40801899 |
samdow
added a commit
to samdow/pytorch
that referenced
this pull request
Nov 7, 2022
Summary: Pull Request resolved: pytorch#88090 X-link: pytorch/torchrec#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@c12f829), this adds the same flag to named_parameters Test Plan: python test/test_nn.py -k test_buffers_and_named_buffers OSS Tests Reviewed By: albanD Differential Revision: D40801899 fbshipit-source-id: 2553cceecae1f37c544275d9841dff0097494813
samdow
added a commit
to samdow/torchrec
that referenced
this pull request
Nov 7, 2022
Summary: X-link: pytorch/pytorch#88090 Pull Request resolved: pytorch#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@672d105), this adds the same flag to named_parameters Reviewed By: albanD Differential Revision: D40801899 fbshipit-source-id: 2adc53cebb5658c639b429bab24d69a106959ff6
samdow
force-pushed
the
export-D40801899
branch
from
57c5116
to
b52a1e0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D40801899 |
samdow
added a commit
to samdow/pytorch
that referenced
this pull request
Nov 7, 2022
Summary: Pull Request resolved: pytorch#88090 X-link: pytorch/torchrec#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@c12f829), this adds the same flag to named_parameters Test Plan: python test/test_nn.py -k test_buffers_and_named_buffers OSS Tests Reviewed By: albanD Differential Revision: D40801899 fbshipit-source-id: 99aad6bb4b4876a81a6a92785f3e40a1c006538a
Summary: X-link: pytorch/pytorch#88090 Pull Request resolved: pytorch#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@672d105), this adds the same flag to named_parameters Reviewed By: albanD Differential Revision: D40801899 fbshipit-source-id: 89ab659ebdc2f916e62609f6e793d426b3a4518b
|
This pull request was exported from Phabricator. Differential Revision: D40801899 |
samdow
force-pushed
the
export-D40801899
branch
from
b52a1e0
to
513ecfb
Compare
samdow
added a commit
to samdow/pytorch
that referenced
this pull request
Nov 8, 2022
Summary: Pull Request resolved: pytorch#88090 X-link: pytorch/torchrec#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@c12f829), this adds the same flag to named_parameters Test Plan: python test/test_nn.py -k test_buffers_and_named_buffers OSS Tests Reviewed By: albanD Differential Revision: D40801899 fbshipit-source-id: 163bfd5052c42b9bd87cb35931d9f7be627e3256
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Nov 9, 2022
Summary: X-link: pytorch/torchrec#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (c12f829), this adds the same flag to named_parameters Test Plan: python test/test_nn.py -k test_buffers_and_named_buffers OSS Tests Differential Revision: D40801899 Pull Request resolved: #88090 Approved by: https://github.com/albanD
lequytra
pushed a commit
to lequytra/torchrec
that referenced
this pull request
Dec 6, 2022
Summary: X-link: pytorch/pytorch#88090 Pull Request resolved: pytorch#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@672d105), this adds the same flag to named_parameters Reviewed By: albanD Differential Revision: D40801899 fbshipit-source-id: 5318259adc6e3c487ccd95aeefecf0a02a1ce79d
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
…orch#88090) Summary: X-link: pytorch/torchrec#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@c12f829), this adds the same flag to named_parameters Test Plan: python test/test_nn.py -k test_buffers_and_named_buffers OSS Tests Differential Revision: D40801899 Pull Request resolved: pytorch#88090 Approved by: https://github.com/albanD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Since the remove_duplicate flag was added to named_buffers in D39493161 (672d105), this adds the same flag to named_parameters
Differential Revision: D40801899