Improve perf by avoiding implicit string creation in c10_cuda_check_implementation #88350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplementation Test Plan: Sandcastle Differential Revision: D40949947 fbshipit-source-id: 2fe74acf0e4311136e75308353b30c8120bbc8ba
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88350
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 FailuresAs of commit 93d191b: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D40949947 |
Skylion007
approved these changes
Nov 2, 2022
soumith
approved these changes
Nov 3, 2022
|
@pytorchbot merge -f "CI error due to infra" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Nov 5, 2022
…mplementation (pytorch#88350) Test Plan: Sandcastle Differential Revision: D40949947 Pull Request resolved: pytorch#88350 Approved by: https://github.com/Skylion007, https://github.com/soumith
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
…mplementation (pytorch#88350) Test Plan: Sandcastle Differential Revision: D40949947 Pull Request resolved: pytorch#88350 Approved by: https://github.com/Skylion007, https://github.com/soumith
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan: Sandcastle
Differential Revision: D40949947