[xnnpack][Bug Fix] Pass serialized model by reference #89089
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two changes - Remove XNNCompiler Dependence on std::string by passing void* - Grab ser_model by reference: This bug was causing data pointers given to xnn_runtime to be freed because ser_model was on the stack. Differential Revision: [D41208380](https://our.internmc.facebook.com/intern/diff/D41208380/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89089
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e5588e6: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mcr229
added a commit
that referenced
this pull request
Nov 15, 2022
Two changes - Remove XNNCompiler Dependence on std::string by passing void* - Grab ser_model by reference: This bug was causing data pointers given to xnn_runtime to be freed because ser_model was on the stack. Differential Revision: [D41208380](https://our.internmc.facebook.com/intern/diff/D41208380/) ghstack-source-id: 173694754 Pull Request resolved: #89089
Two changes - Remove XNNCompiler Dependence on std::string by passing void* - Grab ser_model by reference: This bug was causing data pointers given to xnn_runtime to be freed because ser_model was on the stack. Differential Revision: [D41208380](https://our.internmc.facebook.com/intern/diff/D41208380/) [ghstack-poisoned]
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
Two changes - Remove XNNCompiler Dependence on std::string by passing void* - Grab ser_model by reference: This bug was causing data pointers given to xnn_runtime to be freed because ser_model was on the stack. Differential Revision: [D41208380](https://our.internmc.facebook.com/intern/diff/D41208380/) Pull Request resolved: pytorch#89089 Approved by: https://github.com/digantdesai
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Two changes
Differential Revision: D41208380