-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[xnnpack][lite-int] Freeze/Inline module to remove reference to self #88863
Conversation
We need to inline graph before converting from torchscript to xnnpack flatubuffer. Remove graph dependence on self. This will later help us work with constant data. Differential Revision: [D41049858](https://our.internmc.facebook.com/intern/diff/D41049858/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88863
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7e42487: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
We need to inline graph before converting from torchscript to xnnpack flatubuffer. Remove graph dependence on self. This will later help us work with constant data. Differential Revision: [D41049858](https://our.internmc.facebook.com/intern/diff/D41049858/) ghstack-source-id: 173346132 Pull Request resolved: #88863
…ce to self" We need to inline graph before converting from torchscript to xnnpack flatubuffer. Remove graph dependence on self. This will later help us work with constant data. Differential Revision: [D41049858](https://our.internmc.facebook.com/intern/diff/D41049858/) [ghstack-poisoned]
Pull Request resolved: #88863 We need to inline graph before converting from torchscript to xnnpack flatubuffer. Remove graph dependence on self. This will later help us work with constant data. ghstack-source-id: 173694758 Differential Revision: [D41049858](https://our.internmc.facebook.com/intern/diff/D41049858/)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…ce to self" We need to inline graph before converting from torchscript to xnnpack flatubuffer. Remove graph dependence on self. This will later help us work with constant data. Differential Revision: [D41049858](https://our.internmc.facebook.com/intern/diff/D41049858/) [ghstack-poisoned]
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…ytorch#88863) We need to inline graph before converting from torchscript to xnnpack flatubuffer. Remove graph dependence on self. This will later help us work with constant data. Differential Revision: [D41049858](https://our.internmc.facebook.com/intern/diff/D41049858/) Pull Request resolved: pytorch#88863 Approved by: https://github.com/digantdesai
Stack from ghstack (oldest at bottom):
We need to inline graph before converting from torchscript to xnnpack flatubuffer. Remove graph dependence on self.
This will later help us work with constant data.
Differential Revision: D41049858