Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export c10/[macros|util] headers to be used by internal inductor builds #89249

Closed
wants to merge 1 commit into from
Closed

Export c10/[macros|util] headers to be used by internal inductor builds #89249

wants to merge 1 commit into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Nov 18, 2022

Summary: Fixes package boundary violation that existed in previous implementation

Test Plan: CI

Differential Revision: D41391862

@malfet @facebook-github-bot
Export c10/[macros|util] headers to be used by internal inductor builds
e4b2ac6 
Summary: Fixes package boundary violation that existed in previous implementation

Test Plan: CI

Differential Revision: D41391862

fbshipit-source-id: e73f7647769493de4a92104bdafa78bd2031c101
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 18, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89249

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e4b2ac6:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41391862

@malfet malfet added the topic: not user facing topic category label Nov 18, 2022
@malfet malfet requested a review from dagitses November 18, 2022 00:24
izaitsevfb
izaitsevfb approved these changes Nov 18, 2022
View reviewed changes
c10/macros/build.bzl
name = "headers",
srcs = rules.glob(
["*.h"],
exclude = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the empty exclude can be omitted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps, but this is a copy-n-paste from

pytorch/c10/util/build.bzl

Lines 66 to 70 in 177621a

srcs = rules.glob(
["*.h"],
exclude = [
],
),

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 18, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@malfet @kulinseth
Export c10/[macros|util] headers to be used by internal inductor buil…
b0d8b70 
…ds (pytorch#89249)

Summary: Fixes package boundary violation that existed in previous implementation

Test Plan: CI

Differential Revision: D41391862

Pull Request resolved: pytorch#89249
Approved by: https://github.com/izaitsevfb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izaitsevfb izaitsevfb izaitsevfb approved these changes

@dagitses dagitses Awaiting requested review from dagitses

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@malfet @facebook-github-bot @pytorchmergebot @izaitsevfb