Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export c10/[macros|util] headers to be used by internal inductor builds #89249

Closed
wants to merge 1 commit into from
Closed

Export c10/[macros|util] headers to be used by internal inductor builds #89249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions c10/macros/build.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,12 @@ def define_targets(rules):
"//conditions:default": [],
}),
)
rules.filegroup(
name = "headers",
srcs = rules.glob(
["*.h"],
exclude = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the empty exclude can be omitted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps, but this is a copy-n-paste from

pytorch/c10/util/build.bzl

Lines 66 to 70 in 177621a

srcs = rules.glob(
["*.h"],
exclude = [
],
),

],
),
visibility = ["//:__pkg__"],
)
2 changes: 1 addition & 1 deletion c10/util/build.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,5 +68,5 @@ def define_targets(rules):
exclude = [
],
),
visibility = ["//c10:__pkg__"],
visibility = ["//c10:__pkg__", "//:__pkg__"],
)