Add support for dynamic kwarg to torch._dynamo.optimize #89290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an easier way to enable dynamic shapes for a region. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89290
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2c034cc: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ezyang
added a commit
that referenced
this pull request
Nov 18, 2022
This is an easier way to enable dynamic shapes for a region. Signed-off-by: Edward Z. Yang <ezyangfb.com> ghstack-source-id: 3553c580c6978bf76c154d210525594407fcf396 Pull Request resolved: #89290
github-actions
bot
requested review from
albanD,
anjali411,
antoniojkim,
bdhirsh,
Chillee,
miladm,
SherlockNoMad,
voznesenskym and
wconstab
ezyang
requested review from
soumith
and removed request for
miladm,
wconstab,
Chillee,
albanD,
SherlockNoMad,
bdhirsh,
antoniojkim and
anjali411
jansel
approved these changes
Nov 18, 2022
This is an easier way to enable dynamic shapes for a region. Signed-off-by: Edward Z. Yang <ezyangfb.com> cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
This is an easier way to enable dynamic shapes for a region. Signed-off-by: Edward Z. Yang <ezyangfb.com> cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Nov 19, 2022
This is an easier way to enable dynamic shapes for a region. Signed-off-by: Edward Z. Yang <ezyangfb.com> ghstack-source-id: 6724312a1fb01c1a7bcfa45c3ecc91fc35310193 Pull Request resolved: #89290
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
There's a place in our symbolic shapes branch where we sniff args in a signature for a calling convention before we have this. Let's remember to change it. |
voznesenskym
approved these changes
Nov 19, 2022
|
@voznesenskym wait, surely we aren't sniffing optimize? |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
This is an easier way to enable dynamic shapes for a region. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Pull Request resolved: pytorch#89290 Approved by: https://github.com/soumith, https://github.com/jansel, https://github.com/voznesenskym
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This is an easier way to enable dynamic shapes for a region.
Signed-off-by: Edward Z. Yang ezyang@fb.com
cc @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @chunyuan-w @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire