Set INTERFACE_LINK_DIRECTORIES on caffe2::mkl #89359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that subsequent link commands involving mkl libraries know where to find the libraries if they are in a non-standard location (which is the case if you installed mkl via conda, which is what our standard instructions recommend.) This is kind of a hack, because the MKL libraries are not actually guaranteed to be in $MKL_ROOT/lib (they are for the conda install though). The real fix is to properly use the MKL targets from FindMKL.cmake but thats its own can of fish. See #73008 This fixes pytorch/audio#2784 Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89359
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit 0c2d960: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ezyang
added a commit
that referenced
this pull request
Nov 20, 2022
This ensures that subsequent link commands involving mkl libraries know where to find the libraries if they are in a non-standard location (which is the case if you installed mkl via conda, which is what our standard instructions recommend.) This is kind of a hack, because the MKL libraries are not actually guaranteed to be in $MKL_ROOT/lib (they are for the conda install though). The real fix is to properly use the MKL targets from FindMKL.cmake but thats its own can of fish. See #73008 This fixes pytorch/audio#2784 Signed-off-by: Edward Z. Yang <ezyangfb.com> ghstack-source-id: 65d3516a0f86e464bb27a31978d70828b9bf0ba8 Pull Request resolved: #89359
github-actions
bot
requested review from
albanD,
anjali411,
antoniojkim,
bdhirsh,
Chillee,
miladm,
SherlockNoMad,
voznesenskym and
wconstab
ezyang
requested review from
malfet and
atalman
and removed request for
miladm,
voznesenskym,
wconstab,
Chillee,
albanD,
SherlockNoMad,
bdhirsh,
antoniojkim and
anjali411
ezyang
added
ciflow/binaries
soumith
approved these changes
Nov 20, 2022
|
@pytorchbot merge -f "flaky ci only" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
It looks like this might not be enough; omp dependency isn't setup |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
This ensures that subsequent link commands involving mkl libraries know where to find the libraries if they are in a non-standard location (which is the case if you installed mkl via conda, which is what our standard instructions recommend.) This is kind of a hack, because the MKL libraries are not actually guaranteed to be in $MKL_ROOT/lib (they are for the conda install though). The real fix is to properly use the MKL targets from FindMKL.cmake but thats its own can of fish. See pytorch#73008 This fixes pytorch/audio#2784 Signed-off-by: Edward Z. Yang <ezyang@fb.com> Pull Request resolved: pytorch#89359 Approved by: https://github.com/soumith
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This ensures that subsequent link commands involving mkl libraries
know where to find the libraries if they are in a non-standard
location (which is the case if you installed mkl via conda, which
is what our standard instructions recommend.)
This is kind of a hack, because the MKL libraries are not actually
guaranteed to be in $MKL_ROOT/lib (they are for the conda install
though). The real fix is to properly use the MKL targets from
FindMKL.cmake but thats its own can of fish. See
#73008
This fixes pytorch/audio#2784
Signed-off-by: Edward Z. Yang ezyang@fb.com